WandererXII / lishogi

☗ lishogi.org: the forever free, adless and open source shogi server forked from lichess.org ☗
https://lishogi.org
GNU Affero General Public License v3.0
271 stars 41 forks source link

[Bug] Comments will not be read correctly when exporting CSA file #466

Open ch-suginami opened 3 years ago

ch-suginami commented 3 years ago

When CSA files are exported from study pages with comments, ShogiGUI will not recognize comments correctly. As a result, the shogi board will show many extra pieces.

This is because newline character is now LF, not CR+LF for Windows.

The sample CSA codes is below.

'----------棋譜ファイルの例"example.csa"-----------------
'バージョン
V2.2
'対局者名
N+NAKAHARA
N-YONENAGA
'棋譜情報
'棋戦名
$EVENT:13th World Computer Shogi Championship
'対局場所
$SITE:KAZUSA ARC
'開始日時
$START_TIME:2003/05/03 10:30:00
'終了日時
$END_TIME:2003/05/03 11:11:05
'持ち時間:25分、切れ負け
$TIME_LIMIT:00:25+00
'戦型:矢倉
$OPENING:YAGURA
'平手の局面
P1-KY-KE-GI-KI-OU-KI-GI-KE-KY
P2 * -HI *  *  *  *  * -KA * 
P3-FU-FU-FU-FU-FU-FU-FU-FU-FU
P4 *  *  *  *  *  *  *  *  * 
P5 *  *  *  *  *  *  *  *  * 
P6 *  *  *  *  *  *  *  *  * 
P7+FU+FU+FU+FU+FU+FU+FU+FU+FU
P8 * +KA *  *  *  *  * +HI * 
P9+KY+KE+GI+KI+OU+KI+GI+KE+KY
'先手番
+
+7776FU
-3334FU
+2868HI
'四間飛車の狙いは①飛車を動かすことで囲いやすい②角のラインで攻めれる
-8384FU
+6766FU
-5142OU
'※②の説明に使います
%CHUDAN
'---------------------------------------------------------

This CSA style with LF newline character will not read -8384FU line. So could you change newline character from LF to CR+LF? Thanks!

ddugovic commented 2 years ago

Sorry, with my studies I am failing to reproduce this issue. Which study are you trying to export?