Open CouchTomato87 opened 1 year ago
CouchTomato87
commented
1 year ago 
Also numbers obscure the actual pieces here (on PC). This is in the popup window for analysis
"additionally, if promoted pieces were under their unpromoted pairs it would be faster to find them"
WandererXII
commented
1 year ago Thanks for posting it here! I will just answer here and start separate issues if needed.
checking translated page to Polish, when you choose handicap, names to choose from are in English. (play computer -> from position -> handicap). Also not sure about handicap translation to Fory, but that's another issue.
Yeah handicap names are not translated, I will consider adding them to translations. About 'fory' - you can submit a better alternative to crowdin.
also little bit confused why buttom player has less pieces instead of top one on the diagram
On the bottom is always the player that goes first, do you think this should be changed?
still not clear which player is uwate or shitate without mouse hover option, if they cannot read kanji?
Good point, only solution I can think of is adding a text below each button, that might clutter it a bit, but I will try it.
I tried to win by stalemate, it says "Pat • Shitate zwyciężyły". Does stalemate terminology exist in shogi? Isn't it considered checkmate in a way?
Well checkmate is usually defined as being/delivering check and not being able to escape it. It has 'check' in the name after all, so I left the stalemate logic in, thinking I could always remove it later, but I think you are right, 'officially' (whatever that means) shogi doesn't really know stalemate. Should I remove it and just call it checkmate? Stalemate is so rare, that I don't think this is a pressing issue.
post game analysis translation also sounds weird
crowdin
sorry, half like suggestions rather than bugs
Thanks for the suggestion, I'm glad you took the time to write it out.
in post game discussion study bottom game info shows kanji even though I am on Polish (game time, place etc.) same in English
Currently these work as kif tags, that's why they are in JP, but I also convert them when exporting to CSA, so maybe I will make them just multilang.
(also it says sente/gote even though it was handicap)"
Definitely fixing that one.
WandererXII
commented
1 year ago Also numbers obscure the actual pieces here (on PC). This is in the popup window for analysis
Will try and make them smaller, or just move them down a bit so it's not too small and still readable.
"additionally, if promoted pieces were under their unpromoted pairs it would be faster to find them"
I will try it, there will be some empty spaces (gold and king) that will look weird tho.
CouchTomato87
commented
1 year ago Also numbers obscure the actual pieces here (on PC). This is in the popup window for analysis
Will try and make them smaller, or just move them down a bit so it's not too small and still readable.
"additionally, if promoted pieces were under their unpromoted pairs it would be faster to find them"
I will try it, there will be some empty spaces (gold and king) that will look weird tho.
I wonder if you could make kinda increase the vertical space between the number and the piece? There is still room within that dialog box to do so, it seems.
Regarding the empty spaces, this is actually how it's implemented in Pychess already:
The following were reported by Karolina:
"checking translated page to Polish, when you choose handicap, names to choose from are in English. (play computer -> from position -> handicap). Also not sure about handicap translation to Fory, but that's another issue. also little bit confused why buttom player has less pieces instead of top one on the diagram still not clear which player is uwate or shitate without mouse hover option, if they cannot read kanji? I tried to win by stalemate, it says "Pat • Shitate zwyciężyły". Does stalemate terminology exist in shogi? Isn't it considered checkmate in a way? post game analysis translation also sounds weird sorry, half like suggestions rather than bugs in post game discussion study bottom game info shows kanji even though I am on Polish (game time, place etc.) same in English (also it says sente/gote even though it was handicap)"