WandererXII / lishogi

☗ lishogi.org: the forever free, adless and open source shogi server forked from lichess.org ☗
https://lishogi.org
GNU Affero General Public License v3.0
271 stars 41 forks source link

Unique sets for Kyoto Shogi? #695

Closed CouchTomato87 closed 1 year ago

CouchTomato87 commented 1 year ago

Any thoughts on having Kyoto Shogi have access to unique sets like chu shogi? At Pychess we already have all the images ready, so you'd basically just need to copy them. Two reasons why this may be worth considering:

1) Visually - Using the standard shogi image sets, pieces changing from front to back will change size, which is weird. For example, the small pawn changes to the big rook.

2) Mnemonics - All the specialized Kyoto Shogi sets on Pychess also have mnemonic devices, which makes it much easier to play.

image

image

WandererXII commented 1 year ago

Definitely agree with your points. I might have to rework how piece sets are handled tho, because the list of pieces already can't fit my screen: image Probably to something similar to how Pychess does it - showing only the piece sets for the current variant.

WandererXII commented 1 year ago

https://github.com/WandererXII/lishogi/commit/7fca3ef893013510d251e1459f607d29b8cbb7fd https://github.com/WandererXII/lishogi/commit/8029d2dd47d2cfcd399b3902f32150fb56af6855 https://github.com/WandererXII/lishogi/commit/e3142ed0560f65553b930a6e383cd3821371f385 https://github.com/WandererXII/lishogi/commit/112fdbf8f844cc465176402183728719a0b6b81b

image

Rechefiltr-is-Fire commented 1 year ago

https://github.com/WandererXII/lishogi/issues/701