WandererXII / lishogi

☗ lishogi.org: the forever free, adless and open source shogi server forked from lichess.org ☗
https://lishogi.org
GNU Affero General Public License v3.0
261 stars 40 forks source link

Issue with display in tablet with portrait/vertical mode #801

Open rainfall-1917 opened 4 months ago

rainfall-1917 commented 4 months ago

Shouldnt call it a bug tho, but earlier I created issue #754 Screenshot_20240314-145930_Mull This is how lishogi front page appears on browsers like earlier

Whereas it looks good in this way Screenshot_20240314-145824_Mull

Earlier the issue #754 was completely resolved when I changed the settings> accesibility> font size> {anthing greater than 100}

The issue with the display of board is completely resolved in this update, but when the settings of font size is automatic or equal or less than 100 the front page appears like the 1st image When changed to more than 100, it appears like the 2nd image, which looks ideal.

In the 1st image many wordings are not completely visible

WandererXII commented 4 months ago

Thanks for reporting this, I tweaked the media queries, so let me know if it's good now.

rainfall-1917 commented 4 months ago

Its working great, but many pages do appear as if in desktop mode, like the arena, profile stats and others, as in vertical mode mobile view looks better in my opinion. (If you want I can provide you the images),Also I have observed that a bit of extra info does appears while in desktop view.

Cant confirm for others but in anonymous view, selecting the AI lvl 1, 2 & 3 from presets the game never starts. The online green button is always marked as offline for the anonymous user .

WandererXII commented 4 months ago

Its working great, but many pages do appear as if in desktop mode, like the arena, profile stats and others, as in vertical mode mobile view looks better in my opinion. (If you want I can provide you the images),Also I have observed that a bit of extra info does appears while in desktop view.

Media queries are defined as such:

$mq-width-xx-small: 500px;
$mq-width-x-small: 650px;
$mq-width-small: 800px;
$mq-width-medium: 980px;
$mq-width-large: 1120px;
$mq-width-x-large: 1260px;
$mq-width-xx-large: 2500px;

A7 should be between medium and large, so it hits those breakpoints, maybe I should always force phone view for portrait orientation? Only possible issue could be people using vertical monitors, which I don't know what behavior would be best there. Phone view sometimes hides some info, but it shouldn't be anything too important. If you think something should be shown everywhere let me know and I will change that.

Cant confirm for others but in anonymous view, selecting the AI lvl 1, 2 & 3 from presets the game never starts. The online green button is always marked as offline for the anonymous user .

Thanks for reporting this. That was high priority, I gotta do more testing for anon views, since it's less likely to get reported. Should be fixed now - thanks!