WandererXII / lishogi

☗ lishogi.org: the forever free, adless and open source shogi server forked from lichess.org ☗
https://lishogi.org
GNU Affero General Public License v3.0
261 stars 40 forks source link

Unorthodox Interpretation of Annan Shogi Rules Regarding Nifu #804

Open PraseodymiumSpike opened 4 months ago

PraseodymiumSpike commented 4 months ago

Exact URL where the bug happened https://lishogi.org/variant/annanshogi Steps to reproduce the bug read the page What did you expect to happen? It should state that multiple non-promoted pawns are not allowed on the same file, even if the pawn is moving like another piece. This video and this video both state that this is the rule. However, here, it is shown that it is allowed but only if the pawn that is moving promotes at the same time. But that makes sense as there is a non-promoted and a promoted pawn on the same file, which is allowed. What happened instead? It states, 'it is possible for multiple pawns to end up on the same file. Having multiple pawns on the same file is therefore legal'. Note that this archived website in Japanese seems to state that nifu can be allowed as an alternative rule as long as it isn't caused by a drop, which is the current implementation. However, even that website has chosen to implement the rule under which nifu is not allowed. So I think that lishogi.org should also not allow nifu. Operating system and browser version irrelevant

image

WandererXII commented 4 months ago

Hmm, this would be a drastic change to the rules now. All currently played correspondence annan games would need to be aborted, which isn't that bad I guess. But old games already in the db would get cut off at the first nifu move, which would mean I might as well delete them... Maybe an option is adding a configuration option, one that would allow players to choose which variant ruleset to play - with or without nifu. People requested this for chushogi, since there are two main rulesets, but I was strongly against it, in my opinion it complicates the game creation too much and divides already smaller playerbase, but maybe worth considering...

PraseodymiumSpike commented 4 months ago

There could be a checkbox to allow nifu. Allowing nifu seems to be an actual rule variant, so in my opinion, it makes sense to have a checkbox. Having a checkbox for the chu shogi rule might work as well.

amdewitt commented 1 month ago

You guys should do something similar with Chu Shogi, using the historical and Chu Shogi Renmei presets.