search

WandererXII / lishogi

☗ lishogi.org: the forever free, adless and open source shogi server forked from lichess.org ☗
https://lishogi.org
GNU Affero General Public License v3.0
261 stars 40 forks source link

Detect more inaccuracies #809

Closed ddugovic closed 4 months ago

ddugovic commented 4 months ago

Looking at https://lishogi.org/LCGBUrP6/sente#33 where I made a random move because I couldn't find a plan, I hoped to see something other than "0 inaccuracies" this game.

WandererXII commented 4 months ago

That is a relatively big change, the same number is used for finding puzzles and in insights accuracy calculations, it's also present in the frontend in ceval. Originally submitted here: https://github.com/WandererXII/lishogi/pull/204#issuecomment-782845742 If we want to change the number, some data analysis should probably be run.

Probably related: https://github.com/WandererXII/lishogi/issues/789

Another option might be changing what is considered an inaccuracy/mistake/blunder...

ddugovic commented 4 months ago

Ah... sorry for duplicating issue#789. I should follow up with the submitter of PR#204 to see what data analysis if any they've done or could help with.