WandererXII / lishogi

☗ lishogi.org: the forever free, adless and open source shogi server forked from lichess.org ☗
https://lishogi.org
GNU Affero General Public License v3.0
261 stars 40 forks source link

Make human and bot maximum ply match #836

Closed nhamil closed 4 weeks ago

nhamil commented 1 month ago

Currently, bots have a stricter limit to the maximum plies per game compared to humans. This leads to situations where games will unexpectedly become a draw, despite not being near the 1000 move limit for chushogi (or the 700 move limit for other variants):

It looks like when per-variant move limits were added, bots were given their own limit of 600 moves (which appears to be what games used to be limited to a couple years ago according to https://github.com/WandererXII/lishogi/issues/472#issuecomment-1239640750):

https://github.com/WandererXII/lishogi/blob/65b534483d2e83346ff91131e105f0623ac932d1/modules/game/src/main/Game.scala#L680-L684

This pull request would allow bots to have the exact same move limit as humans for each variant. Feel free to disregard it if there's a reason you feel bots should have a stricter limit, though if that's the case I think it would be helpful to notify bot developers of this difference. Please let me know if there's anything you'd like changed :)

WandererXII commented 4 weeks ago

LGTM, thanks!