WangCheng0116 / pe

0 stars 0 forks source link

Fields are not correctly trimmed #11

Open WangCheng0116 opened 11 months ago

WangCheng0116 commented 11 months ago

add contact -n Aaron Tan -p 12345678 -a Baker Street 12 -e aaron123@gmail.com and
add contact -n Aaron Tan -p 12345678 -a Baker Street 12 -e aaron123@gmail.com (there is an extra white space between Aaron and Tan)
These two commands should be considered the same based the usage in real life. Because we are obviously referring to the same person. However, the application doesn't detect such duplicate errors.

nus-pe-script commented 11 months ago

Team's Response

We believe that this is our check is reasonable enough and this is an edge case that is:

  1. Very much attributed to user error
  2. Can very easily be undone

    Items for the Tester to Verify

    :question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I disagree for the following reasons:

To add on, upon testing, we can discover that the application successfully trims the whitespace before and after the name field, indicating that the dev team has made such assumptions about extra whitespace. But they don't handle the issue well when there's a whitespace in between names.
To achieve the expected behavior, what is needed is just to use the trim() method, which is easy to implement but can greatly enhance user experience.