Wrong icon used for cloudy days or hours

WangDaYeeeeee / GeometricWeather

A Material Design Weather Application

GNU Lesser General Public License v3.0

2.44k stars 186 forks source link

Wrong icon used for cloudy days or hours #215

Open sonora opened 3 years ago

sonora commented 3 years ago

It seems that fo rdays or hours which say 'Cloudy,' 'Mostly cloudy', 'Mostly cloudy with a shower', etc. the app always falsely displays the icon for 'Partly cloudy'?

papjul commented 3 years ago

After #258 is merged, cloudy will correctly report as cloudy. Mostly cloudy will stay Partly cloudy. Mostly cloudy with a shower will stay Rain. Is that OK for you?

sonora commented 3 years ago

I think that's a big improvement, thank you!

Having said that, a lot of information to users is being conveyed just via the icons, so any oversimplification there hurts. It can actually make the display and widgets significantly more useful if more icons of the pool https://developer.accuweather.com/weather-icons were adapted.

papjul commented 3 years ago

I believe icons need to be generic enough to be available in all weather providers and have a unique "live" animation.

sonora commented 3 years ago

Yes, I see. True, of course. Without having tested it yet, looks like this issue could be closed then, thanks again!