Doesn't show weather for Sant-Peterburg in OWM

[RJSDevel]

I found bug in owm provider, sometimes OwmOneCallResult -> Minutely -> precipitation is Float in owm, but in code is int

I don't want create merge request, may be you had fixed it in dev

[papjul]

Minutely precipitation does not exist in OpenWeatherMap (or rather, it is not used, it is not displayed anywhere). Where exactly is this minutely causing you issues? 🤔

[RJSDevel]

You can reproduce this on master - enter Санкт-Петербург, the bug doesn't allow handle information

[RJSDevel]

The issue has been in json converter, it expected int, but float found.

[papjul]

You're right, precipitation is expecting float, however, there is no precipitation in the json converter minutely, so the error is somewhere else. Please copy/paste the exact error you're having (I can't find the city atm, probably due to rate limits).

[RJSDevel]

I can't data had changed, yesterday was problem

[RJSDevel]

Try to write Saint Peterburg(Saint-Peterburg)

[RJSDevel]

OwmOneCallResult -> Minutely -> precipitation

[papjul]

Once again, precipitation is not used in minutely: https://github.com/WangDaYeeeeee/GeometricWeather/blob/master/app/src/main/java/wangdaye/com/geometricweather/weather/converters/OwmResultConverter.java#L355-L376

If you can't reproduce today, neither will I. Please let me know the exact error when you are able to reproduce, and I will do my best to fix it ;)

[RJSDevel]

It doesn't mean that OwmOneCallResult.Minutely doesn't deserialze by Gson The Minutely isn't equal OwmOneCallResult.Minutely

The problem occurs when OwmOneCallResult.Minutely deserialize from json

[papjul]

OK, you originally said the error was in the converter ;)

You mean that the API is given us a float and gson cannot convert it to int, right? I can see indeed in the API documentation that the example us shows a float ;)

You can make a pull request to have the credit for the fix in that case (you can probably do it directly from GitHub edit feature): https://github.com/WangDaYeeeeee/GeometricWeather/blob/master/app/src/main/java/wangdaye/com/geometricweather/weather/json/owm/OwmOneCallResult.java#L48

I'm not the maintainer of the app so I won't be able to merge it, but I developed the Owm service provider, so I know it won't be harmful x)

[RJSDevel]

Yes, you are right! It is my fault. I'll make merge request

[RJSDevel]

Hi! I can't make new branch for merge request - fatal: unable to access 'https://github.com/WangDaYeeeeee/GeometricWeather.git/': The requested URL returned error: 403

[papjul]

You need to fork the project and create the branch on your fork, you can't make a branch directly on this project.

[RJSDevel]

https://github.com/WangDaYeeeeee/GeometricWeather/pull/236