Receiving outdated flood alerts from months ago.

WangDaYeeeeee / GeometricWeather

A Material Design Weather Application

GNU Lesser General Public License v3.0

2.43k stars 187 forks source link

Receiving outdated flood alerts from months ago. #371

Open ph00lt0 opened 2 years ago

ph00lt0 commented 2 years ago

Today I have continuously been receiving many duplicate flood alerts which originate from more than a year ago. There is no clear reason why this is happening.

papjul commented 2 years ago

Please be more specific:

which provider?
which region in the world?
did you receive them all at once or like one every 15 minutes or something?
did you change some settings in the app prior to that? Like enabling alerts
etc

ph00lt0 commented 2 years ago

I'll try to answer your questions:

accuweather
UK
I received first 1 and 15 minutes later a bunch of them at the same time
Didn't change any settings really I just got this app few days ago. Only thing I changed was the icon pack and reduced amount of cards on the homepage and disabled notifications after trying that out.

While writing I only realized that I added a widget of the app today.

papjul commented 2 years ago

There was a slightly different alert issue with AccuWeather and OpenWeather #261.

I checked the source code and I believe the alert API from AccuWeather did send us these alerts. I'm not exactly sure why they did it but according to the source code, we:

deduplicate alerts
sort them by date

But we don't filter outdated alerts.

I couldn't reproduce your issue by taking London for example, so it won't be an easy fix but I believe in the meantime you will no longer receive outdated alerts as you already received them. Could you check again in a few days?

ph00lt0 commented 2 years ago

The alert came from Windsor maybe try that location? I'll let you know if it comes up again.

papjul commented 2 years ago

This is an issue with UK Environment Agency (or with Accu Weather alert system I don't know).

They are reporting a flood alert starting on Feb 2nd but with no end date!

https://www.accuweather.com/en/gb/windsor/sl4-3/weather-warnings/1-326270_1_al

But I can see only one alert here, what other alerts did you see?

ph00lt0 commented 2 years ago

it's the same alert, but the app kept sending notifications about it.

But interesting find, that it has not been closed properly.

ph00lt0 commented 2 years ago

I just got the same alert twice again. It happened at the same time of the widget update.

ph00lt0 commented 2 years ago

Just to update on this, I continuously throughout the day received multiple errors about this, so I turned this feature of for now.