search

WangDaYeeeeee / GeometricWeather

A Material Design Weather Application
GNU Lesser General Public License v3.0
2.44k stars 186 forks source link

Open Weather #395

Open csamolot opened 2 years ago

csamolot commented 2 years ago

Every time I switch to try and use Open weather I get this. When I go back to AccuWeather I get the weather info but I'd prefer to use Open weather. I've tried using my own API key and that didn't help. I've uninstalled it and reinstalled it from GitHub and that didn't help either Screenshot_20220808-151132

papjul commented 2 years ago

Are you sure you didn't do a wrong copy/paste of your API key?

What does it show when you go to https://api.openweathermap.org/data/2.5/onecall?appid=<your-api-key> ? (Replace in the URL)

csamolot commented 2 years ago

I've attached a screenshot

On Mon, Aug 8, 2022, 4:49 PM Julien Papasian @.***> wrote:

Are you sure you didn't do a wrong copy/paste of your API key?

What does it show when you go to https://api.openweathermap.org/data/2.5/onecall?appid= ? (Replace in the URL)

— Reply to this email directly, view it on GitHub https://github.com/WangDaYeeeeee/GeometricWeather/issues/395#issuecomment-1208596283, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKPSGSOFU3IHGRBKMSWUEDVYFXFLANCNFSM556GOIIA . You are receiving this because you authored the thread.Message ID: @.***>

papjul commented 2 years ago

Please post your screenshot on GitHub, we can't see it if you reply by email.

csamolot commented 2 years ago

This is what I get Screenshot_20220808-170249

papjul commented 2 years ago

Your API key seems valid, indeed, please double check your advanced settings in case there are some whitespace or something. I can't see any other explanation.

Otherwise, can you try with another location to see if it's a specific issue?

csamolot commented 2 years ago

I've double checked and no whitespace also tried with different locations and still get the same results

sheltpat commented 2 years ago

I have the exact same issue since today. I'm not sure if an app update caused it, but it gives me both the same app and browser result. My API key has been valid for one and a half months now.

Edit: Downgraded to 3.100_fdroid, working fine again. Maybe there's a bug in 3.102's OpenWeatherMap query.

0-5-0 commented 2 years ago

Seems other weather apps are having the same issue. Something to do with how OpenWeatherMap changed their APIs from 2.5 to 3.0: https://github.com/TylerWilliamson/QuickWeather/issues/41

If you have an old API key then OpenWeatherMap accepts it, if you created a new OpenWeatherMap account/new API key then it uses the new format that requires users enter billing information.

papjul commented 2 years ago

Thank you for figuring out the issue!

I, indeed, noticed that 3.0 was out (and it doesn't seem there are many changes to make). I will have a look at it after pending pull requests are merged. Ping me if I forget.

Para-lyzed commented 2 years ago

It seems that with the change requiring new OpenWeatherMap users to provide billing information to use the OneCall API, OpenWeatherMap may no longer be a good source for weather data going forward. Requiring billing information to utilize a FOSS tool (Geometric Weather) is just absurd and goes completely against user privacy.

399 proposes the use of the met.no API used by other FOSS projects like GNOME Weather and KDE Weather, which would solve this problem in its entirety. The only issue is that it needs to be implemented, tested, and then actually released. With that said, it's concerning that the repo owner @WangDaYeeeeee has been inactive since June 10th, and this problem has been going on since August. The discussion on whether the project is even still alive as per #419 further justifies that concern.

As a new user, I'm essentially completely unable to get weather information for most of the world due to the OpenWeatherMap API change, and I'm not willing to provide billing information just to get weather information on an app that's seemingly meant to be FOSS and privacy-friendly (hence the F-Droid version). If the repo owner was active, I may actually be motivated to implement the met.no API feature myself, but since I am not an Android developer, that would require a lot of dedication to learn enough to properly implement a new API. With no guarantee that this project will ever see another update again, I haven't felt any motivation to make that commitment.

I just wanted to bump this issue and include the potential fix to the OpenWeatherMap issue by adding the met.no API in case anyone here had more experience than myself and was willing to implement it themselves. If the maintainer comes back, I may choose to try it myself if no one has made any progress on it.

julianfairfax commented 1 year ago

It seems that with the change requiring new OpenWeatherMap users to provide billing information to use the OneCall API, OpenWeatherMap may no longer be a good source for weather data going forward. Requiring billing information to utilize a FOSS tool (Geometric Weather) is just absurd and goes completely against user privacy.

399 proposes the use of the met.no API used by other FOSS projects like GNOME Weather and KDE Weather, which would solve this problem in its entirety. The only issue is that it needs to be implemented, tested, and then actually released. With that said, it's concerning that the repo owner @WangDaYeeeeee has been inactive since June 10th, and this problem has been going on since August. The discussion on whether the project is even still alive as per #419 further justifies that concern.

As a new user, I'm essentially completely unable to get weather information for most of the world due to the OpenWeatherMap API change, and I'm not willing to provide billing information just to get weather information on an app that's seemingly meant to be FOSS and privacy-friendly (hence the F-Droid version). If the repo owner was active, I may actually be motivated to implement the met.no API feature myself, but since I am not an Android developer, that would require a lot of dedication to learn enough to properly implement a new API. With no guarantee that this project will ever see another update again, I haven't felt any motivation to make that commitment.

I just wanted to bump this issue and include the potential fix to the OpenWeatherMap issue by adding the met.no API in case anyone here had more experience than myself and was willing to implement it themselves. If the maintainer comes back, I may choose to try it myself if no one has made any progress on it.

I agree with everything said here.

m-p-3 commented 1 year ago

May I suggest this as a potential data source / API?

https://pirateweather.net/