search

WangDaYeeeeee / GeometricWeather

A Material Design Weather Application
GNU Lesser General Public License v3.0
2.41k stars 188 forks source link

The degree icon is too far from the numbers #483

Closed HotarunIchijou closed 1 year ago

HotarunIchijou commented 1 year ago

papjul commented 1 year ago

How do you enter this display mode? Do you have a step-by-step?

The spacing between the number and its unit is correct, however I can see it's missing Celsius or Fahrenheit, and a yellow round shape is overlapping the temperature, so I would like to check.

HotarunIchijou commented 1 year ago

It's a widget. To get it, you should:

  1. Long press to your home screen
  2. Select widgets
  3. Look for Geometric Weather
  4. Choose Material You - Current

Here's also a comparison with google weather widget, I think it should look more like this Google weather widget - left, Geometric weather widget - right

I also noticed that the borders of the widget are too big, you can see it below

HotarunIchijou commented 1 year ago

I noticed that on other widgets the degree icon is also too far from numbers

papjul commented 1 year ago

Ok, so the overlapping is normal if the reference is the Google Weather widget.

Regarding the spacing, the Google widget is wrong, as per SI conventions, there is a spacing between a number and its unit, so nothing wrong on Geometric Weather side ;)

papjul commented 1 year ago

I removed the spacing when ° is alone, but not when written °C or °F. Best would be to always show °C or °F, as 30° makes no sense if you don't say the unit you're using. But as it is commonly used everywhere and we have limited space, let's keep it that way.

HotarunIchijou commented 1 year ago

But how about borders of the widget?

papjul commented 1 year ago

But how about borders of the widget?

I checked the code and I have no idea. I don't use widgets, I only have a Quick Settings tile to check the current weather.

HotarunIchijou commented 1 year ago

Ok. But I think that the previous position of numbers was better, because now the right angle nearby circle looks isn't really good

papjul commented 1 year ago

Ok. But I think that the previous position of numbers was better, because now the right angle nearby circle looks isn't really good

I didn't change the position, can you make a screenshot to point the issue?

HotarunIchijou commented 1 year ago

Of course

papjul commented 1 year ago

Can you draw on the screenshot? The issue is not obvious to me, I don't understand what is the "right angle".

HotarunIchijou commented 1 year ago

Look at bottom of the number "2"