search

WangDaYeeeeee / Mysplash

An Unsplash Client
GNU Lesser General Public License v3.0
701 stars 133 forks source link

German translation #30

Closed CrimsonFork closed 6 years ago

CrimsonFork commented 7 years ago

I've translated your app to German via Stringlate.

You may have to have a look at it first because I've translated some Strings with an underscore which I guess I'm not supposed to.

WangDaYeeeeee commented 7 years ago

Sorry to reply to you so late, I'm really busy this month.

I've alreay sent a new update to the Google play, and added the German language. Really thank you for the translate work man. Have a nice day.

CrimsonFork commented 7 years ago

No problem for me waiting for an answer, don't worry!

I'm using only F-Droid by the way.

CrimsonFork commented 7 years ago

I made an update for the translation and noticed that you linked me in the translator credits, thanks :-)

rugk commented 7 years ago

@OffifialMITX Instead of gists, pull requests would be more useful, would not they?

CrimsonFork commented 7 years ago

You may be totally right but... ... Stringlate doesn't support PRs ... I have absolutely no idea how to use GitHub functions which are not Star/Download/Comment/New Issue. I will learn it once but in the I don't have enough time yet. I'll put it on my ToDo list though, thanks.

rugk commented 7 years ago

It's easy to learn – and clearly useful.

@WangDaYeeeeee, you could of course also use some online-translation service and integrate it here, so users can just use it to translate your app into multiple languages.

mueller-ma commented 7 years ago

Sorry to say that, but you translation is not very good. Many gramar mistakes, e.g. "Betrieben voun Unsplash.com" and often you use unsuitable words, e.g. "VERFOLGER". A "verfolger" is a hunter, not a follower

CrimsonFork commented 7 years ago

The grammar mistakes are most likely because of my small keyboard and you're right, after a while I stopped thinking about the actual meaning of what I'm translating. Thank you for pointing this out, I'm going to take a look at this in the next few days .

CrimsonFork commented 7 years ago

Thanks to @mueller-ma the translation is now better. I've made about 15 changes.

Please set the version number as a non-translateable string. I just had to make this change manually.

rugk commented 7 years ago

So what about a PR finally? For easy PRs you can also user GitHub desktop, if possible. I can also have a look at the translation then.

mueller-ma commented 7 years ago

I have made a PR yesterday with some corrections #44

mueller-ma commented 6 years ago

@OffifialMITX Can be closed?

CrimsonFork commented 6 years ago

I don't have anything against it.