search

WangYihang / gojob

Go(od) Job is a simple job scheduler that supports task retries, logging, and task sharding.
MIT License
8 stars 1 forks source link

remove unused files #8

Closed emar-kar closed 2 months ago

emar-kar commented 3 months ago

Exported functions from those files are not used, and I don't see the point of keeping them. I suggest we can remove them for clean-up?

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 25.21%. Comparing base (746577b) to head (5f371ed).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8 +/- ## ========================================== + Coverage 24.77% 25.21% +0.43% ========================================== Files 26 22 -4 Lines 787 714 -73 ========================================== - Hits 195 180 -15 + Misses 575 517 -58 Partials 17 17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

WangYihang commented 3 months ago

Some of the function is not used due to the lack of examples, I will provide more examples illustrating these functions.

emar-kar commented 3 months ago

I mean, what's the point of having them, if they are not actually part of the base functionality?