WangYueFt / detr3d

MIT License
772 stars 149 forks source link

feature_sampling problem #27

Closed Yvaine closed 2 years ago

Yvaine commented 2 years ago

hi, thank you for your work, i have a problem in feature_sampling function, the following code reference_points_cam = (reference_points_cam - 0.5) * 2 why need multiply 2? Thank you for reply!

zhanglazhuan commented 2 years ago

for torch grid_sampler, the value should be [-1, 1] this code is trans [0, 1] to [-1, 1], I think so

Yvaine commented 2 years ago

for torch grid_sampler, the value should be [-1, 1] this code is trans [0, 1] to [-1, 1], I think so

Thank you~ That's correct.

a1600012888 commented 2 years ago

Thanks, your understanding is correct.