search

WaniKani / Android-Notification

Android Notifier for WaniKani
GNU General Public License v3.0
34 stars 8 forks source link

JP fonts patch persisted through sessions #14

Closed yacoob closed 5 years ago

yacoob commented 10 years ago
  1. Do some reviews, don't finish
  2. Come back to dashboard
  3. Go back to reviews
  4. See this:

screenshot_2013-11-04-09-20-40

There must have been something that reset my session with WK - otherwise, I'd expect to see the same question as I've left at.

s84606 commented 10 years ago

Is this deterministic or does it happen only once in a while? The kanji is the same as the last (unanswered) question of the previous session: correct?

yacoob commented 10 years ago

No, not deterministic. Sorry for mentioning that; but essentially I've tested this just now, and even if I get the spinning crabigator thingy upon returning, and a different question, the patch is OK. Must have been some extra factor there.

Yup, this was the same kanji as the last unanswered question from previous session.

s84606 commented 10 years ago

Ok, here's a possibile fix: https://www.dropbox.com/s/4vz6m93mlx4se6d/WaniKaniMobile-1.8.2pre0.apk since I can't reproduce it in any way, it is the result of a purely deductive process :) If I've spotted the correct reason, a message dialog should appear (and the correct item shall be displayed) when the race condition happens. It can only happen on the first item of a resumed session, as you correctly pointed out.

s84606 commented 10 years ago

As a side note, release 1.8.2 (which is out today), contains this fix