Support vacation mode - Githubissues

WaniKani / Android-Notification

Android Notifier for WaniKani

GNU General Public License v3.0

34 stars 8 forks source link

Support vacation mode #15

Closed yacoob closed 10 years ago

yacoob commented 10 years ago

Given that I'm on vacation, I've turned on Nelly implemented vacation mode in WK. WK Mobile continues to increase number of reviews available for me. It probably shouldn't ;-)

s84606 commented 10 years ago

Yes it's a known issue. Unfortunately at this time there's no way to fix this because those numbers come from the REST API. Since the API does not provide yet a way to check the vacation flag, the app can't even ignore them. I believe the most similar way to simulate the vacation mode is to unset the "Enable notifications" flag

yacoob commented 10 years ago

Looks like information about vacation mode is now available via API.

s84606 commented 10 years ago

Yep. Pushed last commit to github just now. When in vacation mode, now:

Dashboard "next review time" is set accordingly
Next levelup time is pushed in the future

In addition levelup time histograms and averages only display non-vacation days. Finally, dbexport has the new column "number of vacation days per level".

s84606 commented 10 years ago

Implemented in release 1.9