search

WaniKani / Android-Notification

Android Notifier for WaniKani
GNU General Public License v3.0
34 stars 8 forks source link

External Definition Frame loads multiple times #22

Open sashkello opened 9 years ago

sashkello commented 9 years ago

External Definition Frame extension keeps reloading the kanji page and adding more and more copies of itself, to infinity.

s84606 commented 9 years ago

I tried to reproduce this issue, but this does not happen on my phone. Is this happening for a specific site, or for all of them? And is this related to the kanji info page, the vocab info page or during lessons? Could you please provide a screenshot? Thanks!

sashkello commented 9 years ago

It happens when on the info page for both kanji and vocabulary (when I click on any of them in the "Items" tab). I'm not sure about lessons, I don't have any at the moment, I'll check when I get some.

As you can see below, the frames just load one after another. I've collapsed the first one manually to show there is a next one right after it. And at the end of the frame, another starts.

screenshot_2015-04-23-12-43-33 screenshot_2015-04-23-12-43-38

s84606 commented 9 years ago

I could not find a way to reproduce it. Did you try the refresh button? It clears all the cached resources, so there's a slight possibility it could fix your problem. If it does not, I can try and fix the original js code. As soon as you get new lessons, please tell me if they are affected as well, so I know which parts to fix.

sashkello commented 9 years ago

Yep, I did try refresh, doesn't help.

In lessons, it doesn't add new frames, but rather constantly reloads the existing one. I can see the page within the frame reloading every second and my screen jumps around, like when you do a page refresh...

s84606 commented 9 years ago

I think I found a possible explanation of this behaviour. I can't reproduce it but you can download a possible fix from here: https://www.dropbox.com/s/hid6albzsg6x8ig/WaniKaniMobile-1.15.6pre3-eflp0.apk?dl=0

sashkello commented 9 years ago

Mate, that works! Thanks a lot! Don't have lessons to try it on, but works with vocabulary/kanji page with no issues now :)