search

WaniKani / OS-X-Notification

A OS X Notifier App for Wanikani.com
9 stars 3 forks source link

Add 'Visit WaniKani' menu option #3

Closed jessecurry closed 10 years ago

jessecurry commented 10 years ago

I added a Menu option to Visit WaniKani.com, I often found myself wanting to visit the site because I saw the icon in my menu bar, so I figured that I could drop in the option. I also added a waniKaniUrl property since the root Url is now used it more than one place, but didn't wire it into the other methods since I didn't write them.

SebastianSzturo commented 10 years ago

Thank you very much for contributing! :)

jessecurry commented 10 years ago

No problem, what are your thoughts on the profile information in the menu? I like being able to see in quickly, but it makes the menu much heavier.

jessecurry commented 10 years ago

Just spent a bit more time in the code base, moved most of the data into some model objects and setup KVO/Bindings for most of the views. Check it out https://github.com/jessecurry/OS-X-Notification/tree/develop

I'm definitely breaking the law of demeter in a lot of places in the current state, but I plan to refactor a bit before I move the code to master in my fork.

I think that breaking up the responsibilities into separate classes will help make it a little easier to add features in the future. Thoughts?