WanionCane / BiggerCraftingTables

Adding more Crafting Tables!
https://minecraft.curseforge.com/projects/bigger-crafting-tables
Mozilla Public License 2.0
3 stars 3 forks source link

the bigger crafting table doesn't like "null"s #1

Closed Boter316 closed 7 years ago

Boter316 commented 7 years ago

the tables like to get very finicky when I add "nulls" in the place of items, my script is

mods.biggercraftingtables.Big.addShaped(, [ [NeuiS, TrueS, null, TrueS, NeuiS], [TrueS, null, , null, TrueS], [null, Admin, , Admin, null], [TrueS, null, , null, TrueS], [NeuiS, TrueS, null, TrueS, NeuiS] ]);

and the result is 2016-12-31_16 52 54

I do hope you can fix this, I added this mod to my pack for the option of a bigger than normal table but smaller than dire tables, but it does not seem to want to function properly

Boter316 commented 7 years ago

it should look like 2016-12-31_16 55 00

Boter316 commented 7 years ago

the singularity changes colors, so don't worry about that bit, so does the star

WanionCane commented 7 years ago

thanks for the report and for the screenshots, as soon as possible I will fix this.

WanionCane commented 7 years ago

I hope this fix your issue, if it doesn't, feel free to re-open the issue ^^

Boter316 commented 7 years ago

apparently it's not fixed :/ sorry for taking so long to get back to you but here's what should be

2017-03-21_21 55 49 and the script: mods.biggercraftingtables.Big.addShaped(, [ [null, null, Bronze, Bronze, null], [null, Bronze, Stick, Bronze, null], [null, null, Stick, Bronze, null], [null, null, Stick, null, null], [null, null, Stick, null, null] ]);

and here's what the recipe shows 2017-03-21_21 57 04 also, doing either the recipe I coded or the one that shows results in no item being produced, for some reason though this works

2017-03-21_21 58 28 mods.biggercraftingtables.Big.addShaped(, [ [null, Bronze, Stick, Bronze, null], [Bronze, Stick, Stick, Stick, Bronze], [null, Bronze, Stick, Bronze, null], [null, null, Stick, null, null], [null, null, Stick, null, null] ]);

Boter316 commented 7 years ago

don't worry about differences in the ingots, it's the oredictionary, confirmed they (should have) worked with the one that worked

WanionCane commented 7 years ago

omg... not again XD so, could you try with this?

[null, Bronze, Bronze], [Bronze, Stick, Bronze], [null, Stick, Bronze], [null, Stick, null], [null, Stick, null]

idk if MineTweaker supports this, but Bigger Crafting tables supports it, just for curiosity reasons.

Boter316 commented 7 years ago

that does work

WanionCane commented 7 years ago

works? yay!

Boter316 commented 7 years ago

I appreciate you taking the time to look into these things, I like having your mod in my pack, I have a mod that has a 4/4 crafting grid but it doesn't have an nei hookup so you don't know the items are even craftable, so the 5/5 works nicely, and I love that I'm able to halt the dire table crafting until you have the other two, makes for a good thing when I'm trying to tier progression in the pack

WanionCane commented 7 years ago

so, thanks again for helping me with this, I found the bug, was just one variable that was wrong... =/ a fix for this will be released soon, along with many new features =D

Boter316 commented 7 years ago

no problem, I thoroughly test everything before I use it for leisure, I have a lot of resources and can test anything, and the pack I'm working on that plans to include it has enough mods that all compatibility of every mod ever is essentially tested with this modpack's existence (lol) also yes, have a dedicated server and a number of beta testers to work with, so if you have anything you'd like tested I can and am currently do so