WanionCane / UniDict

a mod about unifying all the things.
https://www.curseforge.com/minecraft/mc-mods/unidict
Mozilla Public License 2.0
38 stars 16 forks source link

keepOneEntry blacklist does not prevent items from being hidden in JEI #192

Closed wormzjl closed 3 years ago

wormzjl commented 3 years ago

Describe the bug Set B:autoHideInJEI=true B:keepOneEntry=true

Add something to S:keepOneEntryEntryBlackList

The item does not get stripped of its oredict entry, but the item is hidden in JEI

Expected behavior Item in blacklist should not get hidden

UniDict-1.12.2-3.0.5

ElektroKill commented 3 years ago

Hello, from what I understand you want the entries that are blacklisted from being removed from their respective ore dictionary to also not be hidden in JEI right?

ElektroKill commented 3 years ago

I've added a new config option called keepOneEntryDisableHideFromJEI. if you set it to true the blacklisted entries will not be hidden from JEI. Can you please test it out in this build: UniDict-1.12.2-3.0.6.zip

wormzjl commented 3 years ago

Seems like this config does not work for me, items in blacklist are still hidden

This is my config: https://gist.github.com/wormzjl/87abdc661cc73120a4826d6b000f2ccc

I'm using this mod which adds a special iron ingot / nugget, which I'm trying to prevent it from being unified, you can test with it: https://www.curseforge.com/minecraft/mc-mods/kitsus-forgecraft

ElektroKill commented 3 years ago

The problem is the following: keepOneEntryEntryBlackList expects a list of OreDictionary entries consisting of kind + resourceName for example ingotCopper and not item stack names. If you need a config option that blacklists item stack names I will be happy to try to implement it :) I should probably add some more clarification to the config descriptions...

wormzjl commented 3 years ago

Ah I see, actually this would be what I need - prevent certain items from being unified when the author did something weird.

ElektroKill commented 3 years ago

Isn’t that covered by the itemStacksNamesToIgnore option?

in my original concept for the config option I meant a keepOneEntryStackBlacklist option which does unification but doesn’t apply the keep one entry on it.

wormzjl commented 3 years ago

I did put these items inside that list, but apparently it gets hidden somehow.

ElektroKill commented 3 years ago

Would an option to prevent JEI hiding on specific item stack names fix your problem?

wormzjl commented 3 years ago

There is already a list, but

ElektroKill commented 3 years ago

The current autoHideInJEIEntryBlackList uses OreDictionary entries just like the blacklists. This is why it doesn’t work with keepOneEntry.

ElektroKill commented 3 years ago

Hello,

I added a list to the config which allows removing certain items from JEI removal called autoHideInJEIItemBlackList. Could you please see if the config option solves your problem using this build: UniDict-1.12.2-3.0.6.zip

wormzjl commented 3 years ago

works great for me, thanks!

ElektroKill commented 3 years ago

Good to hear that, will be part of the upcoming 3.0.6 release!