WanionCane / UniDict

a mod about unifying all the things.
https://www.curseforge.com/minecraft/mc-mods/unidict
Mozilla Public License 2.0
39 stars 16 forks source link

[1.12-bug] GregTech Experimental Plates Recipes unusable #201

Open gatoborrachon opened 3 years ago

gatoborrachon commented 3 years ago

Describe the bug When you have UniDict, IC2 and its addon: GregTech Experimental, you will not be able to use the hammer recipes properly.

To Reproduce Steps to reproduce the behavior:

  1. Add IC2, GregTech Experimental and UniDict (with its lib: WanionLib)
  2. Try to make 2 Iron Plates in a Crafting table (1 hammer and 2 ingots, its a mirrored recipe so it has a pattern) with the same Iron Hammer
  3. See error

Expected behavior 1.- You should be able to use any hammer with the oreDict "craftingToolHardHammer" 2.- You should be able to use a hammer at any Damage Value

3.- Screenshot of how things should work (using a damaged and different hammer than the Iron one) 2021-05-18_00 09 19


Screenshots 1.- There you can see how you can create a plate with the 2 ingots (notice how the hammer is full life) 2021-05-17_23 36 16

2.- Now see how the recipes does not work. 2021-05-17_23 36 20

Additional context Well, i would like to use this issue to ask 1 thing: Where can i disable these auto-generated Crafting recipes? sometimes they are wrong (for example, a Bronze Hull from GregTech Experimental outputs 8 Iron ingots, i don't like the recipe nor the wrong output)

EDIT: This is what i mean with the previous statement: 2021-05-19_13 42 07

gatoborrachon commented 3 years ago

UPDATE: I found that tools from PrimalCore seems unaffected by this issue, i think i will open an Issue on their side

1.- PrimalCore Saws work well at any damage value: 2021-05-19_13 41 48

2.- GregTech Experimental's tools doesn't: 2021-05-19_13 41 57

ElektroKill commented 3 years ago

Hello, I will look at this during the weekend, probably damage values or some other data is not properly recreated. Sorry for the delay!

gatoborrachon commented 3 years ago

oh no problem, take the necessary time, many thanks for answer

ElektroKill commented 3 years ago

Hello, I was able to confirm and replicate both complaints and I'm working on a solution.

gatoborrachon commented 3 years ago

ok, let's wait, there's no hurry

ElektroKill commented 3 years ago

Hello, could you test the first issue (hammer issue) with this custom build of the mod? UniDict-1.12.2-3.0.9.zip Please notify me of the results. As for the second issue, I'm still looking into it.

gatoborrachon commented 3 years ago

Sorry for late reply

Please notify me of the results

it works fine, i was able to use any hammer at any damage value

As for the second issue, I'm still looking into it.

mmm, so there's not a way to directly disable these automatic recipes?

nan0bug00 commented 1 month ago

Given the lack of activity on this repo I'm not asking for the second issue in this to be fixed, but could you possibly submit the custom build to curseforge as an alpha or something so I can include it in a modpack without using an override? Need the fix for my modpack.