WanionCane / UniDict

a mod about unifying all the things.
https://www.curseforge.com/minecraft/mc-mods/unidict
Mozilla Public License 2.0
38 stars 16 forks source link

Removing Recipes with CraftTweaker #203

Open SaltSouls opened 3 years ago

SaltSouls commented 3 years ago

It seems when trying to remove UniDict recipes using CraftTweaker, that the recipes will remain even though CT says it has removed them. This may only be the issue when removing by name, haven't tested a full removal.

Steps to reproduce the behavior:

  1. have ImmersiveEngineering, Thaumcraft, CraftTweaker, and UniDict installed
  2. try removing by name UniDicts auto generated iron plate recipe
  3. check recipe in game
  4. big sad, still there
SaltSouls commented 3 years ago

I've also tried removing them using UniDict itself

S:recipeToRemoveList <
        unidict:ingotbrass_x4_size.4
        unidict:ingotbronze_x4_size.4
        unidict:ingotinvar_x3_size.3
        unidict:plateiron_x3_shape.aaa
        unidict:platebrass_x3_shape.aaa
     >

but it doesn't seem to work. Maybe I have the syntax wrong, but it would be nice if there was some kind of explanation for how this works.

gatoborrachon commented 2 years ago

I also wanted to remove these recipes, but no idea, maybe it is impossible? (maybe it requires you to use CraftTweaker?) i will ask to the CleanroomMC if they know what to do (i would recommend you to join their Discord if you still play 1.12 a lot)

Right now i'm having the issue that UniDict doesn't unify the recipes (Crafting Table and other machines from other mods), but idk if it was because i updated UniDict or because i'm using the CleanroomMC's fork of JEI (HadEnoughItems), gonna test it right now

gatoborrachon commented 2 years ago

I found that if you use mods.unidict.removalByKind.get("Crafting").remove("ingot"); it will remove all recipes that have an ingot as an output, although i don't know if it uses the RecipeID, the Registry Name of the output Item or its oreDict, i will do more tests, but by looking here, i see there's not much integration

I also found that no one of these doesn't work

mods.unidict.removalByKind.get("Crafting").remove("unidict:ingotiron_x8_shape.a"); mods.unidict.removalByKind.get("Crafting").remove("ingotiron_x8_shape.a"); mods.unidict.removalByKind.get("Crafting").remove("ingotiron_x8_shape"); mods.unidict.removalByKind.get("Crafting").remove("ingotiron"); recipes.removeByRecipeName("unidict:ingotiron_x8_shape.a"); mods.unidict.removalByKind.get("Crafting").remove("ingotIron");

Auditor3 commented 10 months ago

how would you go about removing the crafting recipe for bronze? the 3 copper and 1 tin in crafting table recipes.removeByRecipeName("unidict:ingotbronze_x4_shape.a");

would it be this in a .zs file?