Wansmer / symbol-usage.nvim

Display references, definitions and implementations of document symbols
MIT License
276 stars 3 forks source link

Bug: extra "Loading…" indicators #24

Closed chrisgrieser closed 6 months ago

chrisgrieser commented 1 year ago

I am not 100% sure how to reproduce this, but I think one way to reproduce this are undos/redos where a function name or function existence is modified.

Pasted image 2023-10-27 at 13 16 15@2x
Wansmer commented 1 year ago

Unfortunately, I am not able to reproduce the bug using undo/redo. If you're able to reproduce it again, please post the action steps, Neovim version, plugin setup and piece of code.

chrisgrieser commented 10 months ago

So, the problem still occurs regularly, I think it's a combination of a function name being modified while having high CPU usage, but that's just a guess, since I cannot reproduce this really.

However, I was thinking, one simple way to kinda workaround this issue could be to allow for customization of the loading-text. In that case one could set the loading-text to an empty string 🙈

Wansmer commented 10 months ago

However, I was thinking, one simple way to kinda workaround this issue could be to allow for customization of the loading-text. In that case one could set the loading-text to an empty string 🙈

You can already do this with request_pending_text = ''.

I will try to investigate the issue with this problem in more detail.

Green0wl commented 8 months ago

This happens almost every time I create a new function in typescript in conjunction with Angular.

mortymacs commented 6 months ago

I have similar issue in Golang.

Wansmer commented 6 months ago

I have similar issue in Golang.

@mortymacs, please describe the steps to reproduce the bug.

mortymacs commented 6 months ago

I have similar issue in Golang.

@mortymacs, please describe the steps to reproduce the bug.

Sure! The steps that I just tried now:

$ mkdir hello && cd hello
$ go mod init hello
$ nvim main.go

Now add this:

package main

type User struct{}

type Class struct{}

func main() {
}

It worked fine before saving, and, as soon as I saved the file, it showed duplication.

This is what it showed: image

Wansmer commented 6 months ago

Ok, I was able to replicate the bug with gopls and after #56 it should work. But most likely it's not the same bug as in the original issue, because the problem was in code that was added later than the creation of this issue. @chrisgrieser, is the original issue still there after #56? (I still can't reproduce it).

chrisgrieser commented 6 months ago

At least on my end, the issue does not occur anymore. Maybe some other commit in the meantime has fixed the issue?

Wansmer commented 6 months ago

Thanks for the info.

Maybe some other commit in the meantime has fixed the issue?

Yeah, maybe. Then I'll close this is issue if the problem no longer occured.