Wanwandada / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

Summary #4

Open mikebutts opened 7 years ago

mikebutts commented 7 years ago

Grade: Meets Expectations

Summary: When looking through these projects I check for it to match the spec, you did. I check for code organization and neatness, no problems here. I then look at the code for inappropriate tags like strong instead span of which you had no problems with. Then I just nit-pick, the only thing I saw was the use of breaks, I never use them, nor should you, use margin-bottom or top in its stead, just keep an eye out for these types of things. Great Job! Next, try to spice up the page, maybe add a background image for the header or some colors to the divs. Coolors.co has some cool schemes you can check out

Wanwandada commented 7 years ago

Thank you very much! I have noted the use of margin. It is not introduced in the course, while I will look for the information of how to use it. Sounds something great :) Thank you again!