search

WapplerSystems / ws_less

less compiler extension for TYPO3
GNU General Public License v2.0
7 stars 24 forks source link

Output file name generation syntax error #39

Open mkrappitz opened 8 months ago

mkrappitz commented 8 months ago

https://github.com/WapplerSystems/ws_less/blob/ac3337922d7944e9e101c612c742bb5e6045c1ff/Classes/Hooks/RenderPreProcessorHook.php#L131

Shouldn't that line be the following instead? I mean you cannot trim() an array anyway and we need a string file name here.

$outputFile = isset($subInnerConf['outputfile']) ? trim($subInnerConf['outputfile']) : null;
rr-it commented 8 months ago

Maybe go for

$outputFile = empty($subInnerConf['outputfile']) ? null : trim($subInnerConf['outputfile']);