WarBean / tps_stn_pytorch

PyTorch implementation of Spatial Transformer Network (STN) with Thin Plate Spline (TPS)
926 stars 155 forks source link

the args' name problem #6

Open TeeyoHuang opened 6 years ago

TeeyoHuang commented 6 years ago

In the args list, you set the grid_size with default value of 4. Then you named two args - args.height, args.width- and set their values according to the grid_size. However, I think the names of these args are misleading!

Actually, the size of the grid in your program is equal to the size of the input image, right? And in the file -mnist_model.py, there is a sentence: grid = source_coordinate.view(batch_size, self.args.image_height, self.args.image_width, 2) So you also know that your args.grid_height and args.grid_width are not the real height and width of the grid in the STN.

the args.grid_size actually refers to the gird of control ponits but not the grid in the STN steps.

So I just think the name of the arg maybe misleading, Of course, the program works very well ! Good job!