edmund-h commented 4 months ago

Changelog:

Update files for 1.12

Completion Tracker:

Modified files - use this page to find which files need updating

VS Code native procedure for checking modified files used by @edmund-h :

add your name next to the folder you are working on
go to the page listed above and locate a file in the folder you are working on in the modified files (white text) section of the CK3 Game Content box
if you do not already have it, add the game files into your VS Code project
locate and right click the file in game files, select Select for Compare
if there is a corresponding file in the GoA2 files, right click it and select Compare with Selected (otherwise move on to the next file
reconcile the game file on the left (deleted text in red) to the GoA2 file on the right (added text in green)
- if added text does not have a #Warcraft comment, you need to check Git Blame to see if we added it. If we did not, make an assessment as to whether the deleted content serves the mod. If you leave it in, leave a comment stating it was removed in 1.12.x in case it causes a problem later. Otherwise, if we did add it, add a #Warcraft comment
- "removed" text is not necessarily deleted by us. new material in the file will show up as "removed". generally, you should just use the arrow button to immediately add it, especially if it is related to a new feature. However, it is also a good idea to check the git blame if you are in doubt to see if and when we removed the text. If you do not add the "removed" content in, add a # warcraft comment with a brief reason as to why. If someone else removed the content and did not leave that comment, then you should add it.
- feel free to ask in development chat if you are in doubt

Common

[x] accolade_icons @edmund-h
[x] accolade_names @edmund-h
[x] achievements @edmund-h
[x] activities @Grekopithikos
[x] ai_goaltypes @Grekopithikos
[x] ai_war_stances @Grekopithikos
[x] artifacts @Grekopithikos
[x] bookmark_portraits @edmund-h
[x] bookmarks @edmund-h
[x] buildings @Grekopithikos
[x] casus_belli_groups @Grekopithikos
[x] casus_belli_types @Grekopithikos
[x] character_backgrounds @edmund-h
[x] character_interaction_categories @edmund-h
[x] character_interactions @edmund-h
[x] character_memory_types @edmund-h
[x] coat_of_arms @edmund-h
[x] combat_effects @edmund-h
[x] combat_phase_events @edmund-h
[x] console_groups @edmund-h
[x] council_positions @edmund-h
[x] council_tasks @Grekopithikos
[x] court_positions @Grekopithikos
[x] court_types @edmund-h
[x] courtier_guest_management @edmund-h
[x] culture @Grekopithikos
[x] customizable_localization @Grekopithikos
[x] deathreasons @Grekopithikos
[x] decisions @Grekopithikos
[x] defines @Grekopithikos
[x] dna_data @edmund-h
[x] dynasties @edmund-h
[x] dynasty_house_motto_inserts @edmund-h
[x] dynasty_house_mottos @edmund-h
[x] dynasty_houses @edmund-h
[x] dynasty_legacies @edmund-h
[x] dynasty_perks @edmund-h
[x] effect_localization @edmund-h
[x] ethnicities @Raged50
[x] event_backgrounds @edmund-h
[x] event_themes @edmund-h
[x] factions @edmund-h
[x] flavorization @edmund-h
[x] game_concepts @edmund-h
[x] game_rules @edmund-h
[x] genes @Raged50
[ ] gfx
[x] governments @edmund-h
[x] holdings @edmund-h
[x] hook_types @edmund-h
[x] house_unities @edmund-h
[x] important_actions @edmund-h
[x] inspirations @edmund-h
[x] landed_titles @edmund-h
[x] laws @edmund-h
[x] lifestyle_perks @edmund-h
[x] men_at_arms_types @edmund-h
[x] messages @edmund-h
[x] modifier_definition_formats @edmund-h
[x] modifiers @edmund-h
[x] named_colors @edmund-h
[x] nicknames @edmund-h
[x] on_action @edmund-h
[x] opinion_modifiers @edmund-h
[x] pool_character_selectors @edmund-h
[x] province_terrain @edmund-h
[x] religion @edmund-h
[x] schemes @edmund-h
[x] script_values @edmund-h
[x] scripted_animations @edmund-h
[x] scripted_character_templates @edmund-h
[x] scripted_effects @edmund-h
[x] scripted_guis @edmund-h
[x] scripted_modifiers @edmund-h
[x] scripted_relations @edmund-h
[x] scripted_rules @edmund-h
[x] scripted_triggers @edmund-h
[x] secret_types @edmund-h
[x] story_cycles @edmund-h
[x] struggle @edmund-h
[x] succession_election @edmund-h
[x] suggestions @edmund-h
[x] traits @edmund-h
[x] travel @edmund-h
[x] trigger_localization @edmund-h
[x] tutorial_lesson_chains @edmund-h
[x] tutorial_lessons @edmund-h
[x] vassal_contracts @edmund-h
[x] vassal_stances @edmund-h
[ ]

Events

[x] activities @edmund-h
[x] artifacts @edmund-h
[x] councilor_task_events @edmund-h
[x] court_events @edmund-h
[x] courtier_guest_management_events @edmund-h
[x] culture_events @edmund-h
[x] death_events @edmund-h
[x] decisions_events @edmund-h
[x] diarchy_events @edmund-h
[x] dlc @edmund-h
[x] education_and_childhood @edmund-h
[x] factions @edmund-h
[x] government_events @edmund-h
[x] interaction_events @edmund-h
[x] lifestyles @edmund-h
[x] nickname_events @edmund-h
[x] prison_events @edmund-h
[x] relations_events @edmund-h
[x] religion_events @edmund-h
[x] scheme_events @edmund-h
[x] story_cycles @edmund-h
[x] stress_events @edmund-h
[x] test_events @edmund-h
[x] trait_specific_events @edmund-h
[x] travel_events @edmund-h
[x] war_events @edmund-h
[x] yearly_events @edmund-h
[x] [top level files] @edmund-h

GFX

[ ] coat_of_arms
[x] court_scene @Chomski2
[x] FX @Chomski2
[ ] interface
[x] map @Chomski2
[x] models @Chomski2
[x] portraits @Chomski2
[x] skins @Chomski2

GUI

[x] custom_gui @helloruhe
[x] decision_view_widgets @helloruhe
[x] preload @helloruhe
[x] scripted_widgets @helloruhe
[x] shared @helloruhe
[x] root dir @helloruhe

History

[ ] joe moether

Localization

[ ] replace > english > culture
[ ] replace > english > dlc
[ ] replace > english > event_localization
[ ] replace > english > gui
[ ] replace > english > names
[ ] [new needed localization]

Error Log

[x] generate_religion_descent_effect @edmund-h

Known Issue Resolutions

[x] Remove Sky Burials @edmund-h
[ ] sink line replacement in log_settings_*.json
[x] scripted trigger is_rightful_liege_of_trigger > is_rightful_liege_of @edmund-h
[x] dead_relative > dead_relation in memories
[x] tooltip_enabled > tooltip_visible
[x] rename county control modifiers
[x] rename development modifiers
[ ]
[ ]
[ ]
[ ]

New Feature Parity Adds

[x] Funerals @Grekopithikos
[ ] Legitimacy Effects
[ ] Cultural Herigage Audio
[ ] Scarred Trait XP
[ ] Add Hospices
[ ] Add Scriptoria
[ ] Elderly age and health modifiers
[ ] Child age and health modifiers

New Feature Spikes - these are to be done in the form of a feature proposal document (add a link to the checklist)

[ ] Legends @edmund-h
[ ] Plagues @ElMariuso
[ ] New Funeral Traditions
[ ] Geographical Region Scope
[ ] Auto Combine Feed Messages

Tests:

[ ] There are no errors in wc files in Documents\Paradox Interactive\Crusader Kings III\logs\error.log except portrait_decals.cpp:101
[ ] The mod takes less than 5.5 GB in the Task Manager (Windows)

How to test:

edmund-h commented 4 months ago

@Grekopithikos can you please check off and add your name to which folders you have checked through? thanks!

helloruhe commented 3 months ago

assigned myself to some gui stuff, will probably start on it Wednesday

Warcraft-GoA-Development-Team / Warcraft-Guardians-of-Azeroth-2

1.12.x update - DRAFT #1373

Changelog:

Completion Tracker:

Tests:

How to test: