1.12.5 update

[edmund-h]

Changelog (from 1.12 fast follow):

• Fix Nerubian Background Error
• Fix Forsaken.9002 killing root character
• Add Missing racial assignment in template
• Add missing character templates
• Add missing racial assignments to create_character
• Re-add missing racial assignments to arriving guests
• Additional fixes for missing race traits for guests/courtiers
• Tooltip fixes

Completion Tracker:

Modified files - use this page to find which files need updating

VS Code native procedure for checking modified files used by :

1. add your name next to the folder you are working on
2. go to the page listed above and locate a file in the folder you are working on in the modified files (white text) section of the CK3 Game Content box
3. if you do not already have it, add the game files into your VS Code project
4. locate and right click the file in game files, select Select for Compare
5. if there is a corresponding file in the GoA2 files, right click it and select Compare with Selected (otherwise move on to the next file
6. reconcile the game file on the left (deleted text in red) to the GoA2 file on the right (added text in green)
   • if added text does not have a #Warcraft comment, you need to check Git Blame to see if we added it. If we did not, make an assessment as to whether the deleted content serves the mod. If you leave it in, leave a comment stating it was removed in 1.12.x in case it causes a problem later. Otherwise, if we did add it, add a #Warcraft comment
   • "removed" text is not necessarily deleted by us. new material in the file will show up as "removed". generally, you should just use the arrow button to immediately add it, especially if it is related to a new feature. However, it is also a good idea to check the git blame if you are in doubt to see if and when we removed the text. If you do not add the "removed" content in, add a # warcraft comment with a brief reason as to why. If someone else removed the content and did not leave that comment, then you should add it.
   • feel free to ask in development chat if you are in doubt

Common

• [x] accolade_icons
• [x] accolade_names
• [x] achievements
• [x] activities
• [x] ai_goaltypes
• [x] ai_war_stances
• [x] artifacts
• [x] bookmark_portraits
• [x] bookmarks
• [x] buildings
• [x] casus_belli_groups
• [x] casus_belli_types
• [x] character_backgrounds
• [x] character_interaction_categories
• [x] character_interactions
• [x] character_memory_types
• [x] coat_of_arms
• [x] combat_effects
• [x] combat_phase_events
• [x] console_groups
• [x] council_positions
• [x] council_tasks
• [x] court_positions
• [x] court_types
• [x] courtier_guest_management
• [x] culture
• [x] customizable_localization
• [x] deathreasons
• [x] decisions
• [x] defines
• [x] dna_data
• [x] dynasties
• [x] dynasty_house_motto_inserts
• [x] dynasty_house_mottos
• [x] dynasty_houses
• [x] dynasty_legacies
• [x] dynasty_perks
• [x] effect_localization
• [x] epidemics
• [x] ethnicities
• [x] event_backgrounds
• [x] event_themes
• [x] factions
• [x] flavorization
• [x] game_concepts
• [x] game_rules
• [ ] genes
• [x] gfx
• [x] governments
• [x] holdings
• [x] hook_types
• [x] house_unities
• [x] important_actions
• [x] inspirations
• [x] landed_titles
• [x] laws
• [x] lifestyle_perks
• [x] men_at_arms_types
• [x] messages
• [x] modifier_definition_formats
• [x] modifiers
• [x] named_colors
• [x] nicknames
• [x] on_action
• [x] opinion_modifiers
• [x] pool_character_selectors
• [x] province_terrain
• [x] religion
• [x] schemes
• [x] script_values
• [x] scripted_animations
• [x] scripted_character_templates
• [x] scripted_effects
• [x] scripted_guis
• [x] scripted_modifiers
• [x] scripted_relations
• [x] scripted_rules
• [x] scripted_triggers
• [x] secret_types
• [x] story_cycles
• [x] struggle
• [x] succession_election
• [x] suggestions
• [x] traits
• [x] travel
• [x] trigger_localization
• [x] tutorial_lesson_chains
• [x] tutorial_lessons
• [x] vassal_contracts
• [x] vassal_stances
• [ ]

Events

• [x] activities
• [x] artifacts
• [x] councilor_task_events
• [x] court_events
• [x] courtier_guest_management_events
• [x] culture_events
• [x] death_events
• [x] decisions_events
• [x] diarchy_events
• [x] dlc
• [x] education_and_childhood
• [x] factions
• [x] government_events
• [x] interaction_events
• [x] lifestyles
• [x] nickname_events
• [x] prison_events
• [x] relations_events
• [x] religion_events
• [x] scheme_events
• [x] story_cycles
• [x] stress_events
• [x] test_events
• [x] trait_specific_events
• [x] travel_events
• [x] war_events
• [x] yearly_events
• [x] [top level files]

GFX

• [ ] coat_of_arms
• [ ] court_scene
• [ ] FX
• [ ] interface
• [ ] map
• [ ] models
• [ ] portraits
• [ ] skins

GUI

• [x] custom_gui
• [x] decision_view_widgets
• [x] preload
• [x] scripted_widgets
• [x] shared
• [x] root dir

History

• [ ]

Localization

• [ ] replace > english > culture
• [ ] replace > english > dlc
• [ ] replace > english > event_localization
• [ ] replace > english > gui
• [ ] replace > english > names
• [ ] [new needed localization]

Tests:

• [ ] There are no errors in wc files in Documents\Paradox Interactive\Crusader Kings III\logs\error.log except portrait_decals.cpp:101
• [ ] The mod takes less than 5.5 GB in the Task Manager (Windows)

How to test:

[Raged50]

checked errorlog and playtest for 20 mins

nothing in errorlog relevant to this update and all graphical issues (nerubians) working, and forsaken event is tested and works fine

requires 1-2 more reviews please

[helloruhe]

fixed minor stuff in errorlog (that didnt really matter but might as well anwyays) LGTM