0.4.3 hotfixes and balancing

[Grekopithikos]

Changelog:

• Added some more characters, such as the Stonefield, Maclure, Thunderwood and Stonehand families, some Riverpaw gnolls, Syndicate thugs, Wyll Benton, Anduin's servant and his wife, Califax, one of Maiev's watchers and many more
• Zul'jin is the ruler of Zul'aman in all 3 current bookmarks
• Amani kings are now called warlords
• Made Anduin Lothar the regent of Llane Wrynn, Bolvar Fordragon the regent of Varian Wrynn, and Lor'themar Theron the regent of Anasterian Sunstrider
• Undead now gives -100 opinion instead of -200 if death magic is a crime
• Pandaren and Furbolgs are now in the same race family, Ursine
• Jinyu and Ankoans are now part of the Murlocoid family thanks to their shared heritage
• Made Gul'dan bald again
• Weak, small and stupid races like kobolds, murlocs, pygmies and hozen have can have 2 more knights
• Removed latent inhuman genes from some human dna characters to prevent their children having stuff like elf ears even when marrying fellow humans
• The Stonefield county is now ruled by the newly added Stonefield family
• Added Mortwake as a county with Mortwake's tower as its barony. Klaven Mortwake rules it instead of the Stonefield county from 598.3.17 and beyond
• Added a Dark Iron Empire that Dagran Thaurissan is the ruler of
• Changed the Astrology tenet of Echo of Life to Order Syncretism
• Dark Troll is no longer the parent culture of Zandalari
• Some cultures ending with -en now use its proper plural form, as well as the Taunka
• The Dark Portal can be enabled if you are of a demonic culture or religion
• Adjusted the age of Tandred Proudmoore as he is the youngest of the family

Developer changelog:

• k_blackrock renamed to k_shadowforge to prevent future confusion
• Changed the filenames of orcish runes to their english meanings.

Tests:

• [ ] There are no errors in wc files in Documents\Paradox Interactive\Crusader Kings III\logs\error.log except portrait_decals.cpp:101
• [ ] The mod takes less than 5.5 GB in the Task Manager (Windows)

How to test:

[ValianBlue]

Key

• ✔️ All features are working as intended.
• ❔ Unsure if features were properly tested, or are working as intended.
• 🟡 Unable to test.
• ❌ Features are not working or not implemented.

---

Added some more characters

I'm not sure which characters you are referring to without digging into the code. I've exempted this from my test. 🟡

---

Zul'jin is the ruler of Zul'aman in all 3 current bookmarks

This appears to be true. ✔️

583


603


605


---

Amani kings are now called warlords

Zul'jin has the correct "Warlord" title. For further testing, I replaced Magni with an Amani ruler, and the title was correctly replaced. ✔️



---

Made Anduin Lothar the regent of Llane Wrynn, Bolvar Fordragon the regent of Varian Wrynn, and Lor'themar Theron the regent of Anasterian Sunstrider

Anduin is the correct regent for Wrynn. In the 603 start, Fordragon is the correct regent for Varian. However, in the 583 start, Dar'Khan acts as regent for Anasterian. Theron is the correct regent in the 603 start, so I am not sure what your full intent is. ❔

Lothar/Wrynn


Wrynn/Fordragon


Dar'Khan/Sunstrider (583)


Theron/Sunstrider (603)


---

Undead now gives -100 opinion instead of -200 if death magic is a crime

Playing as Sylvanas, I checked her relations with Archbishop Benedictus (Holy Light faith—where Death Magic is criminal). His malus is -100, which appears to be correct. ✔️


---

Pandaren and Furbolgs are now in the same race family, Ursine

This appears to be working correctly. ✔️

Pandaren


Furbolg


---

Made Gul'dan bald again

He appears to be bald. ✔️


---

Weak, small and stupid races like kobolds and murlocs have can have 2 more knights

This appears to be working correctly, however I will note that Kobolds have a cultural tradition: "Strength in Numbers" that applies a -2 Knight capacity penalty. Given that, there seems to be a conflict-of-design. I'd either remove the -2 penalty from the tradition, or not remove the +2 bonus you have given them in this update. ❔

Kobold Knights


Murloc Knights


---

Removed latent inhuman genes from human dna

I am not sure how to effectively test this, so I will exempt it. 🟡

---

The Stonefield county is now ruled by the Stonefield family

In the 583 bookmark, "Countess Mildred" is the ruler of the county. She is of the Stonefield dynasty. ✔️


---

Added Mortwake as a county with Mortwake's tower as its barony. Klaven Mortwake rules it instead of the Stonefield county

In the 583 bookmark, "Countess Valeriia" is the ruler. I believe this is an auto-generated character. Klaven Mortwake appears to be the steward for the County of Northfield, instead. ❌

Countess Valeriia


Klaven Mortwake


---

Overall Comments

The majority of my tests were successful. However, you wrote nothing in the "How to Test" section, which meant that there were some items I could not address. Be sure to include important details in that section for the future, it's in the template for a reason.

Furthermore, I'm not sure what your full intent with some of these features was. The more specific you can be with the changelog, the better. I've written comments to explain my thought process while testing, but this does take up testing time that could otherwise be contributed to other PRs.

Cheers, -@ValianBlue

[robmart]

Removed latent inhuman genes from human dna

I am not sure how to effectively test this, so I will exempt it. 🟡

The removed latent genes do not need to be tested.

On a side note, wow your review is amazing.

[Rimaka94]

• Karl Philips character has Undead trait in TFT start but should not, probably needs to be moved away from Ghost Forest / Tranquillien. (https://wowpedia.fandom.com/wiki/Commander_Karl_Philips)
  Screenshot

• Should references to k_blackrock and k_blackrock_adj be removed from wc_custom_titles_l_english/french/german/spanish as it's no longer used anywhere?
• For the history of c_mortwake, remove/replace references to Valeriia Nikolay? (looks like a placeholder character, courtier in Northrend) 583.1.1={holder=310070} #Valeriia[310070] \# Conquered by the Horde 587.10.1={holder=10050} #Orgrim[2001] \# Retaken by Stormwind 589.11.1={holder=310070} #Valeriia[310070] \# Defias Stronghold 598.3.17={ holder = 5815 #Klaven liege = d_defias_brotherhood }
  Screenshot

• Unlocalized text for ' Culture has the Demonic Cultural Pillar'. Mousing over Demonic shows a bulletpoint of 'culture_parameter_extraplanar_origin'. You can find this in the criteria for Upgrade of the Dark Portal.
  • Also very minor, the text shown to the player for 'culture { has_cultural_pillar = heritage_demonic }' has an extra space at the beginning, as can be seen in the same screenshot. This could be due to the next issue described.
    Screenshot

• The check for religion = religion:doombringer is outside of the OR statement for dark_portal_building_enabled_trigger. I believe this is because culture { has_cultural_pillar = heritage_demonic } should be culture = { has_cultural_pillar = heritage_demonic } on both the 'OR' and 'trigger_if' statements.
  Screenshot

[Rimaka94]

• Spelling error in wc_cultural_traditions_l_english.yml > culture_parameter_elder_culture
  Screenshot

culture_parameter_elder_culture:0 "From the wisdom of an [wc_elder_race|E], this culture gets up tp #P 20%#! reduced impact of #N harmful events#!." change to culture_parameter_elder_culture:0 "From the wisdom of an [wc_elder_race|E], this culture gets up to #P 20%#! reduced impact of #N harmful events#!."

(change 'tp' to 'to')

[Rimaka94]

From error.log, doesn't look related to your changes but does exist:

[13:14:37][jomini_trigger.cpp:681]: Inconsistent trigger scopes (province vs. culture) infile: common/buildings/wc_special_buildings.txt line: 2656

cosmic_observatory = { is_enabled = { OR = { has_innovation = innovation_archmage

has_innovation probably needs scoping to holder's culture