Rimaka94
commented
3 days ago Test Criteria
:x: Check that Necromancy spells are working as their Descriptions state. :x: Check that Necromancy perks are working as their Descriptions state. 🔶 Without debug_mode enabled, you have access to both Magic character interactions:
- wc_magic_give_disease_interaction
- wc_magic_epiemic_interaction
Marks: ✅ - working as expected ❌ - not working as expected ⚠️ - was unable to confirm if working as expected, needs more testing/confirmation 🔶 - may or may not be an issue, noted for your discretion
In-depth Testing
🧟 Reanimator Branch
- ✅ Raise Dead properly allows a menu to cast a Raise Dead spell on a dead target. Target is raised with the specified Trait.
- 🔶 When a character is raised, their "old" character seems to become related to a Drogbar in my playthrough. I'm assuming this is intentional and not necessarily an issue, in order to allow the "new" character to take the place of the old character. However, this caused a weird situation where I raised my Grandfather, but the "old" grandfather character is still showing as my Grandparent, so now my Great-grandfather is showing as the placeholder Drogbar character. This also caused my family tree to split, as can be seen in screenshot below. This isn't necessarily a big deal, but wanted to make a note of it.
- 🔶 I can raise "Missing/Vanished" characters such as Aegwynn or Deathwing. Not necessarily a functional issue as Vanished characters are (I believe) considered Dead to the game, but seems like it shouldn't be possible.
- 🔶 It is really simple to raise incredibly strong or important characters such as Ysera or Deathwing. Not a functional issue.
[SCREENSHOT] Raise Dead broken family tree
- ✅ Frost Fever works properly with both Give Disease and Ritual: Epidemic.
- ✅ Death Coil properly gives bonuses to Undead characters (Undead, Vampire, Ghoul, etc) and properly counts as a hostile spell with negative effect toward the living.
- ❌ Death Coil shows an incorrect portrait on the Dodge/Hit banner when targeting a Living character, but shows the correct target name and applies the effect to the correct target.
- ❌ Death Grip does not move the target army toward the caster's army or any direction, when I am commander of my army nearby.
- ✅ Death Grip does properly apply the modifier for -75% army movement speed.
- ❌
wc_death_grip_modifieris missing localization. - ❌ Error in localization on the Effects tab when targeting an army: "ERROR:[this_recipient.GetShortUIName] moves one province towards your army."
- ❌ Eternal Suffering does not state that it allows you to be able to raise Banshees in perk description.
- ✅ Raise Dead: Banshee properly allows for raising of female High Elf characters. However, there may be issues. See below.
- 🔶 The requirements state the character must be Elven, but you cannot raise Night Elves (for example) as a Banshee. This may be confusing due to what the requirement is stating.
- ❌ Fleshcrafting does not state that it allows you to be able to raise Abominations in perk description.
- ✅ Ritual: Supreme Raise Dead properly allows you to turn yourself into a Revenant/Lich, or raise a dead character into a Revenant/Lich.
- 🔶 If Raise Dead is on cooldown you cannot do Revenant/Lich on a dead character, but I do not think this is necessarily an issue. Could cause more issues if this was not the case.
- ❌ If you cast Raise Dead on a target that is currently the target of Supreme Raise Dead, you will create two characters. If the Raise Dead finishes before Supreme Raise Dead, the Supreme Raise Dead character will only be raised as a regular undead, rather than a Lich/Revenant. The second character created will be created as a Lowborn of no dynasty.
- ❌ Localization on the hoverover tooltip in spellbok for Effects states you can change a living character into Lich/Revenant, this should probably be changed as you cannot target other living characters, only yourself.
- ✅ Ritual: Army of the Dead properly gives Special Soldiers army of scaling size based on the amount of development sacrificed.
- ❌ Localization on hoverover tooltip in spellbook for Effects has some bad text: "The size of this army scales based on the development sacrificed and your GetLifestyle('death_magic_lifestyle') perk count.
- ❌ Localization misspell on hoverover tooltip in spellbook for Effects: "Sacrifice the Development of the target county so summon a legion of the dead." Need to change "so" to "to".
- ❌ Localization missing for
raised_undead_troops. This is the name of the Special Soldiers you receive upon finishing casting. - 🔶 It might be worth stating that these are raised as Special Soldiers. The Effects tab says "You get an army of X men in Province", but they don't actually get raised. They go into the Special Soldiers pool, so the player may not realize they have to go to the Military tab to find these. Overall, not an issue, but I can forsee someone asking "why did I not summon an army of the dead in my province when I finished casting?"
💀 Deathbringer Branch
- ❌ Give Disease is properly giving most diseases to the target, but there are some specific issues.
- ❌ The Great Pox selection gives Lover's Pox instead.
- 🔶 In a seemingly rare case, Give Disease will show 'Gains the Trait' for the disease twice in the cast window, but only for some diseases and only for specific characters. Bloody Flux for example will show this, while Ill or Lover's Pox will only show once for the same character. Basically all diseases, when this bug happens, except for Ill or Lover's Pox will show twice. HOWEVER, when casting is complete, the character is not given two copies of the disease. I have only been able to recreate this on one character, so I am unsure of the requirements to cause this to happen. stalvan-save-disease-issue.zip - Enter the save, search for Prince Vulvari of Stormwind (the Count of Eastvale), cast Give Disease, and you'll notice some of his selections try to give the same disease twice.
- 🔶 If the target already has the disease, the cast does nothing, but allows you to still attempt to cast that specific disease.
- 🔶 The target does not get the disease until around ~10 or so days after spell finishes casting, though this may be expected.
- 🔶 There is no popup that tells you the target gains the affliction, but this may be expected.
[SCREENSHOTS] Give Diseases issues
  - ✅ Death and Decay properly adds modifier to target county.
- ✅ Enemy armies of the caster are properly applied each malus. Confirmed this does not apply to self/allies. (attrition while raiding, supply duration/capacity)
- ✅ Development decline is properly added.
- ❌ Localization error in Death and Decay county modifier. "Casted by ERROR:[this_recipient.GetShortUIName]"
[SCREENSHOT] Death and Decay Localization Error
ERROR:[this_recipient.GetShortUIName]
- ✅ Raise Dead: Ghoul is working as expected.
- ✅ Crypt Fever is properly given with Give Disease.
- ✅ Cripple correctly applies Crippled debuff character modifier.
- ❌ The hoverover tooltip in spellbook for the Effects localization is incorrect for Cripple, currently using Death and Decay's tooltip text.
- ✅ Improved Body properly has a chance to steal a trait / kill target / wound target in most cases. It also properly only lets you select targets you have imprisoned. See issues below for specific problems.
- ✅ Properly upgrades intellect/strength/appearance traits when targeting a character with a higher rank of these.
- ❌ When trying to steal "Strong", successfully stealing it will also kill the target. This seems to be the only case this happens, whereas the target always survives if any other trait is stolen. Should it be that the target dies in all cases when you successfully steal a trait? If so, Strong is the only one that is working as expected.
- ❌ "Elegant" is not a valid target, despite being listed as a Physical Trait.
- 🔶 Magic physical traits such as "Magic-soaked", "Magical", are not valid targets but in-game are listed as Physical Traits. It might not be intended to steal these, but there is a discrepancy as the spell states you can "steal a positive Physical Trait".
[SCREENSHOTS] Improved Body - Strong trait vs Other Traits
 - 🔶 Perk 8 missing.
- ✅ Ritual: Epidemic properly starts the chosen epidemic in the target county.
- ❌ In the Effects screen after selecting target, there is an unlocalized text showing:
epidemic_tt. - ❌ Canceling the epidemic selection before choosing a plague puts all Rituals on cooldown.
- ⚠️ I did not test every epidemic selection, may need more testing to confirm each selection. The ones I did test (Frost Fever, Bubonic Plague) worked properly.
- ❌ In the Effects screen after selecting target, there is an unlocalized text showing:
[SCREENSHOT] Epidemic ritual localization issue
🩸 Hematurge Branch
- ✅ Coagulation (Rank 1) properly removes wounded.
- 🔶 Coagulation (Rank 2) can't be tested as there are currently no poisons, as expected.
- ✅ Coagulation (Rank 3) properly downgrades/removes magic illnesses, and heals major injuries.
- ✅ Blood Boil properly has a chance to give the Blood Plague disease to all characters in target army.
- ✅ Blood Plague is properly given with Give Disease.
- ❌
wc_plagued_meopinion modifier has no localization. - ❌ Spell Hit banner has bad localization (" the effects of Blood Boil.")
- ❌ On the localization for failing due to target's resistances, there is an error. "Because of ERROR:[this_recipient.GetShortUINamePossessive] Death Magic School Resistance, this spell has no effect.
[SCREENSHOTS] Blood Boil all localization issues
    - ✅ Raise Dead: Vampire works as expected.
- ❌ With my current video settings, the Vampire description text clips the final word out of the box.
[SCREENSHOT] Raise Dead: Vampire localization clipping outside box
- ✅ Strangulate properly prevents target from being able to cast a spell while modifier is applied.
- 🔶 Perk 8 missing.
- ✅ Ritual: Crimson Binding applies modifier to target in your prison. When you are targeted for death, the target with the modifier is instead slain in your place.
- ❌ Localization error in spellbook hover Effects: "Summon an ERROR:[crimson_binding] upon the target province.
- ❌ Localization missing for
wc_crimson_binding_modifier. - ❌ When effect is applied, the description for wc_crimson_binding_modifier incorrectly refers to the target of the cast, rather than the caster. As an example, it states "Casted by Franz Mistmantle", my target, when it should state "casted by Stalvan Mistmantle". It is worth noting that the effect still works on the correct targets, despite this.
[SCREENSHOTS] Ritual: Crimson Binding localization errors
   🗒️ All other issues
- ⚠️ There appears to be a rare case where "Spell cancelled" toast pops up for spells such as Give Disease or Ritual: Epidemic to pop up again when something else is canceled - in my case, when I canceled out of the Execute menu on a prisoner. I am uncertain how I was able to produce this however.
- ⚠️ This may be related to another issue I am seeing. The word "trait_" will be appending to some options in menus at times, such as the Execute menu. What was once "Sacrifice" will now become "trait_Sacrifice" as can be seen in the screenshot. In one occurrence, when I canceled the execute (as can be seen in the screenshots), I received a "Spell cancelled" toast for a spell I had not cast in a very long time.
[SCREENSHOT] `trait_` randomly showing in other menus, Spell cast Cancelled randomly appearing
 EDIT: separated perk feedback to the perk branch
Changelog:
Developer changelog:
TODO:
Art TODO:
Tests:
wcfiles inDocuments\Paradox Interactive\Crusader Kings III\logs\error.logexceptportrait_decals.cpp:101How to test:
death_magic_tree_1_perk_3,death_magic_tree_3_perk_2(Boil Blood), anddeath_magic_tree_2_perk_5.