Warcraft-GoA-Development-Team / Warcraft-Guardians-of-Azeroth-2

"Guardians of Azeroth" is a mod for Crusader Kings 3 with a worldwide development team, based on the Warcraft universe by Blizzard Entertainment. In this mod, our team is working to recreate the world of Azeroth in all of its glory, particularly focusing on the story of the classic Warcraft strategy games and World of Warcraft Classic.
83 stars 65 forks source link

Theocracy rulers cannot perform basic functions #1480

Open edmund-h opened 1 week ago

edmund-h commented 1 week ago

I was playing as the Kaldorei to get feel for how they would work with an administrative government. I realized that no one in my court qualifies for any court positions. Looking at the code, I realized that this is because most court positions are disallowed from being filled by clergy, and everyone in your court and your vassals courts count as clergy.

I'm honestly shocked that no one has noticed this before whilst playing night elves since we (rather carelessly) allowed people to play as theocracy vassals this summer.

Fortunately, the decision to bring Administrative government to the Night Elves will resolve the largest potential source of complaints regarding this issue. Unfortunately, our decision to let anyone play as a theocratic vassal means that there will still be complaints; and I'm sure that the forthcoming Holy Light branch will make it worse (unless @ElMariuso has fixed this).

So here's what we need to do:

  1. Find out how deep this rabbit hole goes. We need a full regression test of every normal action that a Theocracy ruler can normally take. Whoever does that can report here with everything we find.
  2. We need to create a new definition of "clergy" for the purpose of resolving this issue. As I understand, it's kind of an under the hood term, so it may require us doing something fucky and may never fully be fixed; or I could totally be wrong and it's easy.
  3. Apply this fix to every issue and THOROUGHLY TEST to make sure Theocracies have all the functions of a normal ruler.