search

Warcraft-GoA-Development-Team / Warcraft-Guardians-of-Azeroth

"Guardians of Azeroth" is a mod with a worldwide development team, based on the Warcraft universe by Blizzard Entertainment. In this mod, our team is working to recreate the world of Azeroth in all of its glory, particularly focusing on the story of the classic Warcraft strategy games and World of Warcraft Classic.
https://www.patreon.com/thesomething
91 stars 51 forks source link

[BUG] | Zoroastrian modifiers on Holy Light characters #578

Open rhotus opened 5 years ago

rhotus commented 5 years ago

DO NOT REMOVE PRE-EXISTING LINES

Mod Version 1.5

What expansions do you have installed? All

Please explain your issue in as much detail as possible: One of my courtiers has the Sag-e Aabi trait and adopted a holy otter as a Holy Light follower. Should only be for Zoroastrians

Steps to reproduce the issue: Unsure

Upload an attachment below: .zip of your save, or screenshots: ck2_11

zumbak04 commented 5 years ago

You can try it vanilla. Since 3.2.0, courtiers can randomly get pet-modifiers including Zoroastrian ones. Localization is bug though. Will mark it as Paradox bug.

zumbak04 commented 5 years ago

Did an oopsie, not closing it till its fixed.

MemeWizard commented 5 years ago

Bug report: https://forum.paradoxplaza.com/forum/index.php?threads/ck-ii-3-2-1-azce-event-lt-61003-can-give-courtier-sacred-zoroastrian-pet.1192814/

DJScias commented 5 years ago

Was this not fixed by 5e5fca8a9c857313e26a6a52fce1a8af3e5b8a53 by having added ai = no?

Or would the proper fix in this just disable this event from the mod?

MemeWizard commented 5 years ago

Was this not fixed by 5e5fca8 by having added ai = no?

Event that gives modifiers to AI courtiers actually fires for player, but for some reason, paradox put ai = no trigger in event trigger and not into event pre-trigger, so it's only optimization thing and don't actually fix the bug.

DJScias commented 5 years ago

Correct me if I'm wrong, but it's triggered through on_yearly_pulse in 00_on_actions.txt which is something you can't make "players-only" unless it's within that same event (which is now done by both Zumbak and Paradox).

Which means the only way to 'fix' it entirely would be to comment out the following line, no? https://github.com/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/blob/463d21b3950c6d83aa8789dee55ce79fe2784fc0/common/on_actions/00_on_actions.txt#L166

Or did I misunderstand what you were saying?

MemeWizard commented 5 years ago

Correct me if I'm wrong, but it's triggered through on_yearly_pulse in 00_on_actions.txt which is something you can't make "players-only"

You can make it player-only if you put ai = no in trigger or pre-trigger. Preferably in pre-trigger (this is what Zumbak did in 5e5fca8), since it's checked before trigger block and save performance.

Click to expand ![image](https://user-images.githubusercontent.com/46576860/67192037-76623800-f3fb-11e9-8b24-1b5e525e5eec.png)
MemeWizard commented 5 years ago

Which means the only way to 'fix' it entirely would be to comment out the following line, no?

changing give_random_character_modifier_effect in \common\scripted_effects\00_scripted_effects also can fix it

DJScias commented 5 years ago

Understood.

Thank you for the thorough explanation @MemeWizard. I'll let @zumbak04 decide if he'd rather comment out the line in 00_on_actions.txt or the give_random_character_modifier_effect.

My personal preference is the former since it means the event itself doesn't have to happen at all and thus saves performance.

zumbak04 commented 5 years ago

Thank you for the thorough explanation @MemeWizard. I'll let @zumbak04 decide if he'd rather comment out the line in 00_on_actions.txt or the give_random_character_modifier_effect.

@DJScias huh? Why it should be commented out? Only localization is problematic, no?

MemeWizard commented 5 years ago

Only localization is problematic, no?

Courtiers kinda shouldn't have modifier that gives -15% national revolt risk