10/5/22 Shadow Priest changes

[seanpeters86]

Main Changes

• [x] talents moved around
• [x] dark void no longer hasted
• [x] shadow crash no longer hasted
• [x] mind blast insanity and damage nerfed
• [x] mind spike insanity and damage nerfed
• [x] auspicious spirits insanity nerfed
• [x] vampiric touch insanity nerfed
• [x] shadow word: pain insanity nerfed
• [x] mind flay: insanity insanity nerfed
• [x] idol of c'thun insanity nerfed and in AoE no longer generates insanity per target
• [x] mind flay insanity generation nerfed
• [x] mindbender insanity generation nerfed
• [x] hallucinations insanity nerfed
• [x] dark void insanity nerfed targets increased to 16
• [x] echoing void damage nerfed
• [x] idol of yogg-saron is now 100 apparitions and giga buffed
• [x] surge of darkness dmg increase buffed
• [x] mind sear damage buffed
• [x] devouring plague damage buffed
• [x] void bolt damage increased
• [x] coalescing shadows nerfed
• [x] mind melt nerfed
• [x] check maddening touch

Other Changes

• [x] t29 2-piece moved to spelldata
• [x] t29 4-piece moved to spelldata
• [x] Yogg-Saron stacks now have a buff duration
• [ ] inescapable torment data changed
• [x] Puppet Master effect 1 trigger data changed?
• [ ] Check value of Shadowfiend insanity/melee dmg compared to simc
• [x] Check value of Mindbender melee dmg compared to simc
• [x] check rank 1 maddening touch insanity gain value in-game/simc

[seanpeters86]

Noticed Idol of C'thun data was off, new spells:

• Void Lasher Mind Sear: 394976 (cast) -> 394979 (tick)
• Insanity seems to be stored in 377358 now, hard to tell since both tendrils give 2 insanity per tick

This is wired up already with the new spells but should check if damage matches in-game.

[seanpeters86]

fixes the remainder checks https://github.com/simulationcraft/simc/pull/6809