Dragonflight SimC TODOs

[seanpeters86]

Class Talents (shadow relevant only)

• [x] Shadow Word: Death (confirm CD now that rank 2 is baseline)
• [x] Holy Nova 🙃
• [x] Masochism
• [x] Depth of the Shadows (potential APL var to use this at full stacks?)
• [x] Rhapsody 🙃
• [x] Psychic Voice
• [x] Apathy
• [x] Improved Fade
• [x] Power Word: Shield
• [x] Twist of Fate (check if spelldata is fixed)
• [x] Improved Mind Blast (confirm values)
• [x] Halo
• [x] Divine Star
• [x] Manipulation
• [x] Shattered Perceptions
  • [x] No values in game, check this again after it is implemented in-game
• [x] Light's Inspiration
• [x] Crystalline Reflection
• [x] Twins of the Sun Priestess -> PI on pets?
• [x] Void Shield
• [x] Death and Madness
  • [x] Look at reset( true ) and make sure thats what we want

Shadow Talents

• [x] Mind Sear now costs insanity
  • [x] https://github.com/simulationcraft/simc/pull/6715
• [x] Mind Spike
  • [x] Mind Blast crit increase from debuff automagic
  • [x] Currently not affected by Shadowform/Voidform/ToF, check in-game + make a bug or fix
  • [x] check if this scales with Mastery in-game and add to simc if so
• [x] Surge of Darkness
  • [x] Mind Spike damage increase automagic
• [x] Mind Melt
• [x] Dark Ascension
  • [x] consider adjusting how parse_buff_effects work to dynamically check buff value
  • [x] validate other spells are properly getting buffed, only tested mind blast
• [x] Piercing Shadows
  • [x] Confirm which spells can proc this
• [x] Mind Flay: Insanity
  • [x] verify it works with all mind flay related things in the base spell still
  • [x] check if we need some apl conditions to check what we are currently casting (id?)
  • [x] change find_spell to put the ID somewhere we can easy check
• [x] Derangement Check Mind Sear
• [x] Surrender to Madness (confirm CD is 2m)
• [x] Fiending Dark
• [x] Mastermind Crit Chance/Damage Testing after bugfix
• [x] Dispersion healing + Intagibility
• [x] Idol of Y'Shaarj spell data
• [x] Shadow Crash now applies Vampiric Touch to 4 targets
• [x] Pain of Death
• [x] Dark Evangelism
• [x] Tormented Spirits
• [x] Tithe Evasion
• [x] Vampiric Insight (remove extra mind blast charge)
• [x] Mental Fortitude
• [x] Mental Decay
• [x] Maddening Touch
• [x] Whispers of the Damned
• [x] Derangement
• [x] Void Eruption (confirm CD is 2m)
• [x] Monomania rework
• [x] Mastermind
• [x] Insidious Ire (confirm values)
• [x] Mind Devourer (confirm values)
• [x] Ancient Madness (confirm point scaling is working)
• [x] Lunacy
• [x] Hungering Void (ensure works correctly with new values in spelldata)
• [x] Psychic Link
• [x] Dark Void is back, applies SW:P to 8 targets
• [x] Searing Nightmare has been removed

Others

• [x] make sure stats are correct for 60-70

[seanpeters86]

9/7 changes

• [x] pathing changes
• [x] re-check halo/divine star damages at various ranges
• [x] check what changed with hallucinations
• [x] Shadow Orbs is implemented as Coalescing Shadows
  • [x] check if this works with Mind Flay: Insanity
• [x] Dark Ascension generates Insanity
• [x] Dark Evangelism is procced by Void Torrent
• [x] Dark Void targets updated
• [x] Death and Madness added a cooldown to the second trigger. Also check if spelldata is easier to work with now
• [x] Deathspeaker
  • [x] check if this procs on hit as well, right now just wired up on tick
• [x] Harnessed Shadows
• [x] Y'Shaarj spelldata might work now
• [x] Pain of Death values changed and is now a rank talent
• [x] Puppet Master
• [x] Vampiric Insight data has changed, looks like they also removed the extra charge now
• [x] Check how Mind Blast CD interacts with Haste
• [x] Verify Manipulation values are correct, looks nerfed?
• [x] Rhapsody values adjusted
• [x] Mindgames no longer grants mana/insanity but reversed damage is higher
• [x] Check Depth of the Shadows (looks like they added circle of healing?)
• [x] Holy Word: Life renamed
• [x] Check Throes of Pain
• [x] Check SW:D cooldown
• [x] Painbreaker Psalm removed
• [x] Mind Sear is no longer affected by haste? (might be a bug?)

[seanpeters86]

9/13 changes

• [x] angelic feather data swap
• [x] tithe evasion check
• [x] check mind blast cd
• [x] throes of pain spelldata check now that its 2 points
• [x] twist of fate data might be fixed
• [x] hallucinations is baseline again
• [x] mind spike no longer removes dots
• [x] mind spike mind blast crit moved to mind melt
• [x] mind sear ticks_zero
• [x] mind devourer is now a 1 point node that also affects mind sear
• [x] malediction now works on void torrent as well, 2 point talent
• [x] voidform base duration buffed
• [x] ancient madness now also works with dark ascension
• [x] vampiric insight -> shadowy insight and now triggers from sw:p

[seanpeters86]

9/22 changes

• [x] mastermind is gone
• [x] Screms of the void (mono) (untested)
• [x] inescapable (SFP)
• [x] Encroaching (the dp node)
• [x] MFI implementation change, (untested)
• [x] DA 1 min (automagic)
• [x] VF extension
• [x] SI flat %
• [x] MD 2 point 10/20% (untested)
• [x] Flay added to PL (untested)