search

WardCunningham / Smallest-Federated-Wiki

This wiki innovates by: 1. federated sharing, 2. drag refactoring and 3. data visualization.
http://wardcunningham.github.com/
GNU General Public License v2.0
1.21k stars 177 forks source link

rename express server to sfwd #99

Open pmuellr opened 12 years ago

pmuellr commented 12 years ago

In the comments for pull request 98, Ward mentioned:

Nick is looking to rename "server/express/bin/server". Is there a problem with that name? The name "sfw-express" seems to encode information already present in the path to the file.

Seems to me, following typical web server naming idioms, the server should be named "#{thing-it-serves}d". So sfwd would be the name.

Or perhaps since there are two servers, it should be called one of:

I think I like that first one. When the day comes when there is a single reference server, we can rename whichever that is to sfwd

Also, we should look at adding a bin entry to the package.json, so that when folks do an npm -g install, it will install the binary in a nice place. See, for example, https://github.com/jashkenas/coffee-script/blob/master/package.json

nrn commented 12 years ago

I'm starting to think that just adding the .js back to server/express/bin/server.js may be the way to go. The name of the file doesn't have to be same as the global command when installed with npm -g, see https://github.com/substack/node-browserify/blob/master/package.json#L7

For global commands I do like the "d" at the end to denote a daemon, it helps to make sense of the commands.

I've been waiting on finishing up the package.json with a bin entry and real package versions ranges, etc. until the server/express code stops changing so much. I'm hoping it will have calmed down some in 2 weeks or so.