search

WardCunningham / remodeling

The original wiki rewritten as a single page application
929 stars 99 forks source link

Fix mixed HTTPS/HTTP content #30

Closed shuttle1987 closed 4 years ago

shuttle1987 commented 5 years ago

Modern browsers will block all HTTP requests from a HTTPS loaded page. This PR fixes that issue by using HTTPS links everywhere.

WardCunningham commented 5 years ago

Thanks for this contribution.

Our TLS implementation is new so I will have to check this thoroughly. My own thought was to drop the protocol prefix entirely which I believe is a more compatible solution. This is especially important for the external link markup translation on line 141.

shuttle1987 commented 5 years ago

Dropping the prefix entirely is completely reasonable if you want more compatibility.

friendlyanon commented 4 years ago

For how long is the site going to be left in an unusable state when visiting it using the expected default HTTPS protocol?

WardCunningham commented 4 years ago

Thanks @shuttle1987 and @friendlyanon for your patience and @pcunning for pushing this work through especially the TLS support on the aging c2.com server and adjustments to modern github pages #38.