search

WardCunningham / wiki-plugin-graph

Describe and render a subgraph where nodes might be page titles.
2 stars 2 forks source link

Node description only shown in last graph instance #4

Open almereyda opened 6 years ago

almereyda commented 6 years ago

When hovering any node in a lineup of graphs, such as http://jon.patterns.wiki.transformap.co/view/the-geographic-distribution/view/meta-stabilisation-of-non-representational-plateaus/view/a-tempospatial--or-spatiotemporal--investigation/view/revealing-unintentional-meshworks-of-tribal-swarms/view/value-flows/view/unconditional-redistribution-and-peer-matching/view/lineup-viewer, the description text of it will only be shown below the most right instance of the graph plugin.

bildschirmfoto vom 2018-04-10 03-13-12

Expected would be to see the description of the node below the graph where it is being hovered.

WardCunningham commented 6 years ago

This would seem to be inadvertent rebinding of hover event handler or the $item variable it uses. The code looks simple enough but clearly isn't working right. Perhaps this works right when opening pages one at a time which would implicate some async problem. https://github.com/WardCunningham/wiki-plugin-graph/blob/master/client/graph.coffee#L190-L196

This should probably show hover results within the visible plugin. We've made similar revisions to other plugins which makes it easer to understand what result comes from what activity. https://github.com/fedwiki/wiki-plugin-search/pull/9