search

Wargus / stratagus

The Stratagus strategy game engine
GNU General Public License v2.0
615 stars 115 forks source link

edge scroll (down+right only) broken #682

Closed MamiyaOtaru closed 1 month ago

MamiyaOtaru commented 1 month ago

Compiled from git today.

Scrolling with the mouse on the edge of the screen (or window, in windowed mode) works in all directions but down+right. If the cursor graphic changes to the down+right arrow, no scrolling happens.

Linux. Same behavior in Wayland or Xorg

MamiyaOtaru commented 1 month ago

I'd blame line 201 in interface.h: constexpr unsigned int ScrollRightDown = ScrollRight | ScrollLeft; /// scroll right + down

from https://github.com/Wargus/stratagus/commit/cc11b81ce287f36ea938dce58e2b5989d286a5a3 only been broken for 8 months haha. No one noticed?

edit confirm changing to constexpr unsigned int ScrollRightDown = ScrollDown | ScrollRight; /// scroll right + down allows down/right scroll

MamiyaOtaru commented 1 month ago

TY! It's great that you are maintaining this project and refreshing the code. I just have to wonder how often you actually play the game. Cause now it scrolls down and left instead of doing nothing at all, but it's still not down and right. Like fire the game up and try it out the fix or something :D

And I gave you the working line in my comment.. should have done a pull request I guess.

Not mad, just bemused

Jarod42 commented 1 month ago

I launch the game, but doesn't play full game most of the time. But indeed, for this "trivial" fix, I have just compile it :-/ Sorry again for the trouble.