Wargus / war1gus

Importer and scripts for Warcraft: Orcs and Humans
GNU General Public License v2.0
102 stars 13 forks source link

Doesn't work for Linux #414

Open aknight2015 opened 1 year ago

aknight2015 commented 1 year ago

Reguardless of the version of Warcraft 1 and 2 used, it crashes with "An error with quotes has occured." I've used the GoG installer, crashes with error. Physical disk, error. Pointing to the data.war file, error. Pop!_OS (Ubuntu Distro) is the platform. All those version I tried worked with Lutris just fine, so the data files are fine. I want to use War1gus because of the updated features.

timfel commented 1 year ago

Please try to run the extractor on the console and post console output.

timfel commented 1 year ago

Also, please refer to the first minutes of https://youtu.be/6a4dy16q49c that show how to extract and what problems can occur.

aknight2015 commented 1 year ago

So, if I try to run it from the desktop it extracts all files into the home directory, which causes the error. You gave me the idea to change to a different director (Downloads) in the console, and then run it. War1gus works fine from command. Everything extracted perfectly. Wargus (Warcraft 2) doesn't. Did the same thing for extraction for 2, but when it prompts for the expansion data or GOG installer, it doesn't recognize the Battle.net version GOG installer. I point to the Battle.net GoG installer, and it does the base game extraction all over again, then prompts again. But I'm thrilled to find out, it's a matter of permissions for the Home directory. Perhaps you should implement a way for the user to determine where the temporarily extracted files are stored. Also, please don't close this issue. Lets try and get War1gus solved first.

timfel commented 1 year ago

I point to the Battle.net GoG installer, and it does the base game extraction all over again, then prompts again

Yes, Wargus always prompts again, but if you used the battle.net gog installer and the extraction ran successfully once, then you have everything.

aknight2015 commented 1 year ago

Yeah. I figured that out when I tested it on a whim. But I stand strong by the the fact the installer should prompt you where you want the files extracted. It helps keep system files safe, and helps with clean up as the installer doesn't clean up the files.

timfel commented 1 year ago

I'm not sure I understand - the innoextract files are extracted to std::filesystem::temp_directory_path, which should be in /tmp. The converted game files are stored to .stratagus/data.wargus, which they have to be, since that is what the launcher uses and there's no other configuration. If you want more control over these things, you can already simply use the wartool and stratagus binaries directly. Am I misunderstanding something?

aknight2015 commented 1 year ago

They aren't. When I use the desktop shortcut it extracts everything into the Home directory. When I used the command line everything was extracted into whatever directory I was in. So if I was in the Downloads directory in terminal, it would extract them in terminal.

timfel commented 1 year ago

Huh. Ok, I'll check and make sure it uses /tmp or whatever $TMPDIR is.

timfel commented 1 year ago

Wait, you said that the physical disc didn't work either? If the physical disk is used, nothing is extracted and it installs straight into $HOME/.stratagus/data.Wargus. Are you saying it did not install into that folder?

aknight2015 commented 1 year ago

What I'm saying is, when I extracted to any other folder other than Home, everything went perfectly.

timfel commented 1 year ago

What I'm saying is, when I extracted to any other folder other than Home, everything went perfectly.

I still don't fully get it. You literally just did this?

$ cd ~/Downoads
$ wargus
aknight2015 commented 1 year ago

Yes, in terminal. When I didn't use terminal, I used the .desktop icon, it extracted everything to the Home folder. It doesn't make sense to me either, but that's what happened.