search

Wargus / wargus

Importer and scripts for Warcraft II: Tides of Darkness, the expansion Beyond the Dark Portal, and Aleonas Tales
GNU General Public License v2.0
357 stars 55 forks source link

Fmv streched #330

Closed pelupessy closed 4 years ago

pelupessy commented 4 years ago

Screenshot_2020-06-14_14-22-07 Latest version from launchpad on Ubuntu 20.04 on 1080p monitor. (image windowed, but fullscreen has the same problem)

FMV's are stretched only horizontally.

Expected behaviour: vertical stretch to keep the original aspect ratio for fmv.

Edit: aspect ratio of background artwork is also wrong (eg: menu and mission briefings).

timfel commented 4 years ago

With widescreen resolutions, this is expected. The UI doesn't keep the aspect ratio of the original. This was (and still is) the desired behaviour for some people. Aspect ratio correct scaling is implemented and default in master and will be in the next release, with an option to go back to the old behaviour of stretching to fill the screen.

timfel commented 4 years ago

The fmv's between the DOS and Battle.net versions have different aspect ratio, which we try to account for in the extraction tool. It's possible, though, that something is broken there. The intro does indeed have a different aspect ratio. It should 320x160, whereas the other videos are 320x144

On Thu, 25 Jun 2020 at 01:46, pelupessy notifications@github.com wrote:

Hmmm, is this implemented separately for fmv's?

Looking at the fmv files (in .stratagus), they seem a bit strange: they are all in 4:3 aspect ratio, but, other than the intro, they look squeezed horizontally. The intro looks correct, but has black bars, resulting in it looking squeezed vertically when it is played in wargus. I would expect the intro to be cropped to remove the black bars, then scaled to full 16:9, the other fmv's stretched to full 16:9, but the other artwork merely scaled while preserving their aspect ratio.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Wargus/wargus/issues/330#issuecomment-649131757, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALJG4BEIQFK7LUNKIK4DDRYKF55ANCNFSM4N5I4OTA .

timfel commented 4 years ago

Ah, I see, I guess you are using the DOS CD for extraction? I got confused, and the fix for the aspect ratio didn't make it into the 2.4.3 release. It will be in the next version

pelupessy commented 4 years ago

Thanks for the info! Yes, the data I am using comes from the DOS CD.