Wargus / wargus

Importer and scripts for Warcraft II: Tides of Darkness, the expansion Beyond the Dark Portal, and Aleonas Tales
GNU General Public License v2.0
357 stars 55 forks source link

Fix for https://github.com/Wargus/stratagus/issues/270 #331

Closed timfel closed 4 years ago

timfel commented 4 years ago

Let corpses always have 0 vision. Instead, generate animation step to spawn revealer when unit dies, to implement the initial unit sight range, reduction to 1, and then nothing.

timfel commented 4 years ago

@ipochto could you take a look if this looks reasonable to you? There are some inconsistencies with how corpses work (for one thing, they last different length for different units). This solution makes it that any destroyed unit consistently still gives you vision for a little bit, just like you described in https://github.com/Wargus/stratagus/issues/270. I'm not sure if that's actually correct for buildings or flying units, since these do not have a corpse. But in my WC2 manual it actually says (translated from German) 'whenever one of your units dies, the knowledge it had of the battlefield becomes quickly outdated and the area is soon covered again by the fog of war" - so I think it should apply to all my units :)