Wargus / wargus

Importer and scripts for Warcraft II: Tides of Darkness, the expansion Beyond the Dark Portal, and Aleonas Tales
GNU General Public License v2.0
357 stars 55 forks source link

[BDP] Wrong units on Human mission 7 #358

Closed elrandira closed 3 years ago

elrandira commented 3 years ago

Describe the bug You are supposed to start the mission with 3 paladins with exorcism and healling instead you have knights lvl 1.

To Reproduce Play mission 7 of human campaign in expension Beyond the dark portal.

Expected behavior Start the mission with 3 paladins lvl 4 with healing and exorcism

Screenshots and Logs This video shows what is expected: https://youtu.be/TB9ByMHXtzM?t=2933 This is from Wargus: image

Desktop (please complete the following information):

elrandira commented 3 years ago

Oops, sorry duplicate of https://github.com/Wargus/wargus/issues/341

elrandira commented 3 years ago

I was curious and end up digging into the code. In pud.cpp::UnitScriptNames there are few unknown units and wonder if it could be these missing paladins.. Are there any shareable documentations on the content of install.exe from the BNE or how PUD are written?

timfel commented 3 years ago

i don't think its the unknown units. the upgrades already researched are stored in the mission and read out from there, but the way the paladin upgrade works in wargus is different from the original game, so we need a bit of extra code in Lua to fix this

Erenussocrates commented 3 years ago

All you need to do is change the corresponding Knight unit into paladin in the .sms file.

timfel commented 3 years ago

it's not that simple, the sms file is extracted, and the original wc2 map has knights there. the way it mus work is when the paladin upgrade is researched already, we should trigger replacement of the knights upon game start.