Wargus / wargus

Importer and scripts for Warcraft II: Tides of Darkness, the expansion Beyond the Dark Portal, and Aleonas Tales
GNU General Public License v2.0
357 stars 55 forks source link

Extraction error when using BNE edition without tome assets #365

Open fvasco opened 3 years ago

fvasco commented 3 years ago

I downloaded the italian version of Warcraft 2 here https://archive.org/details/W2BNECDITA I am using wargus 3.0.0-0~202012191004~ubuntu21.04.1

I mount the Warcraft CD, I found the file install.exe

$ md5sum install.exe 
b9a123ad486f5d0674238de31f51fa4c  install.exe

I tried to install Warcraft using wargus, I got an error.

I reproduced it with this command

$ wartool -r -v install.exe /some-empty-dir
Extracting from expansion subdir
Could not find Warcraft 2 Data

Is this version of Warcraft supported? How I can fix that error?

Operating System: Kubuntu 21.04
KDE Plasma Version: 5.21.4
KDE Frameworks Version: 5.80.0
Qt Version: 5.15.2
Kernel Version: 5.11.0-17-generic
OS Type: 64-bit
Graphics Platform: X11
Processors: 4 × AMD A8-3870 APU with Radeon(tm) HD Graphics
Memory: 11.2 GiB of RAM
Graphics Processor: GeForce GTX 1060 3GB/PCIe/SSE2
SimoneStarace commented 3 years ago

Hello @fvasco I never tried this method but have you tried to install Warcraft 2 first and then Wargus? I always do this. I first install Warcraft 2 through Wine. After this I install Wargus and then Wargus needs a file called install.mpq, or something, from the directory where you have installed Warcraft 2.

timfel commented 3 years ago

I don't know this version. The Italian DOS version is definitely supported, and I think the BNE editions are all supported as well. I don't know what archive that is, it seems at least a legal gray area since Warcraft 2 is still being sold. I would recommend to buy an original game on GoG or some other channel. The GoG version is tested, and most DOS versions are, too, including the italian one.

fvasco commented 3 years ago

Hi @SimoneStarace there is nothing similar to install.mpq

├── Maps
│   ├── Classic
│   │   ├── Expansion
│   │   │   ├── Scenario
│   │   │   │   ├── 4_step.pud
│   │   │   │   ├── Anarchy.pud
│   │   │   │   ├── Burn_It.pud
│   │   │   │   ├── Chess.pud
│   │   │   │   ├── DeadMeet.pud
│   │   │   │   ├── Falsie.pud
│   │   │   │   ├── FireRing.pud
│   │   │   │   ├── Football.pud
│   │   │   │   ├── Fortress.pud
│   │   │   │   ├── GrtWall.pud
│   │   │   │   ├── Heroes1.pud
│   │   │   │   ├── Heroes2.pud
│   │   │   │   ├── Invasion.pud
│   │   │   │   ├── Jail.pud
│   │   │   │   ├── MagIsle.pud
│   │   │   │   ├── Massacre.pud
│   │   │   │   ├── Midland.pud
│   │   │   │   ├── MinasTir.pud
│   │   │   │   ├── Onslaugh.pud
│   │   │   │   ├── Rescue.pud
│   │   │   │   ├── Sacrific.pud
│   │   │   │   ├── Sparta.pud
│   │   │   │   ├── Stone.pud
│   │   │   │   ├── Suicide.pud
│   │   │   │   ├── Time.pud
│   │   │   │   ├── TrenchWar.pud
│   │   │   │   ├── WaterRes.pud
│   │   │   │   └── Wish.pud
│   │   │   ├── 3vs3.pud
│   │   │   ├── 3vs5.pud
│   │   │   ├── Arena.pud
│   │   │   ├── Atols.pud
│   │   │   ├── Battle_1.pud
│   │   │   ├── Battle_2.pud
│   │   │   ├── BigEars.pud
│   │   │   ├── BlackGld.pud
│   │   │   ├── Collapse.pud
│   │   │   ├── Crowded.pud
│   │   │   ├── Diamond.pud
│   │   │   ├── Dup.pud
│   │   │   ├── Friends.pud
│   │   │   ├── Fun4Three.pud
│   │   │   ├── Gauntlet.pud
│   │   │   ├── Hell.pud
│   │   │   ├── Hourglas.pud
│   │   │   ├── Icewall.pud
│   │   │   ├── Ironcros.pud
│   │   │   ├── Isle.pud
│   │   │   ├── JimLand.pud
│   │   │   ├── Kanthar.pud
│   │   │   ├── Khing.pud
│   │   │   ├── MntnPass.pud
│   │   │   ├── Passes.pud
│   │   │   ├── Plots.pud
│   │   │   ├── Raiders.pud
│   │   │   ├── Ring.pud
│   │   │   ├── RiversX.pud
│   │   │   ├── RockMaze.pud
│   │   │   ├── SeaWar.pud
│   │   │   ├── Shared.pud
│   │   │   ├── Tandalos.pud
│   │   │   ├── TheRiver.pud
│   │   │   ├── theSiege.pud
│   │   │   ├── Tourney.pud
│   │   │   ├── TwinHrbr.pud
│   │   │   ├── Up4Grabs.pud
│   │   │   ├── Us.pud
│   │   │   ├── Web.pud
│   │   │   └── WizWar.pud
│   │   ├── Scenario
│   │   │   ├── Alamo.pud
│   │   │   ├── Channel.pud
│   │   │   ├── Death.pud
│   │   │   ├── Dragon.pud
│   │   │   ├── Icebrdge.pud
│   │   │   ├── Islands.pud
│   │   │   ├── Land_Sea.pud
│   │   │   └── Mutton.pud
│   │   ├── A continent to explore.pud
│   │   ├── Bridge to bridge combat.pud
│   │   ├── Critter attack!.pud
│   │   ├── Crossover.pud
│   │   ├── Cross the streams.pud
│   │   ├── Death in the middle.pud
│   │   ├── Fierce ocean combat.pud
│   │   ├── Garden of War.pud
│   │   ├── Gold mines.pud
│   │   ├── Gold Separates East & West.pud
│   │   ├── High seas combat.pud
│   │   ├── Islands in the stream.pud
│   │   ├── Mine the center.pud
│   │   ├── Mysterious Dragon Isle.pud
│   │   ├── No way out of this maze.pud
│   │   ├── Nowhere to run or hide.pud
│   │   ├── Oil is the key.pud
│   │   ├── One way in, one way out.pud
│   │   ├── Opposing city-states.pud
│   │   ├── Plains of snow.pud
│   │   ├── River fork.pud
│   │   ├── Rivers.pud
│   │   ├── Skull Isle.pud
│   │   ├── The four corners.pud
│   │   ├── The spiral.pud
│   │   ├── Three ways to cross.pud
│   │   ├── Unyielding stone fortresses.pud
│   │   └── X marks the spot.pud
│   ├── Ladder
│   │   ├── Arctic Circle BNE.pud
│   │   ├── Bridge to bridge combat BNE.pud
│   │   ├── Fierce ocean combat BNE.pud
│   │   ├── Forest Trail BNE.pud
│   │   ├── Frog Legs BNE.pud
│   │   ├── Garden of war BNE.pud
│   │   ├── High seas combat BNE.pud
│   │   ├── Mine in the center BNE.pud
│   │   ├── No way out of this maze BNE.pud
│   │   ├── Plains of snow BNE.pud
│   │   ├── Skull isle BNE.pud
│   │   ├── The four corners BNE.pud
│   │   └── The spiral BNE.pud
│   ├── Scenario
│   │   ├── A Tight Spot BNE.pud
│   │   ├── Bombs Away BNE.pud
│   │   ├── Fire in the Water BNE.pud
│   │   ├── Horse Shoe Island BNE.pud
│   │   ├── Ice Fortress BNE.pud
│   │   ├── Instant Action BNE.pud
│   │   ├── Invasion BNE.pud
│   │   ├── Opposites Attract BNE.pud
│   │   └── Ramparts BNE.pud
│   ├── All You Need BNE.pud
│   ├── Ant Trails BNE.pud
│   ├── Big Rock Candy Mountain BNE.pud
│   ├── Cramped BNE.pud
│   ├── Crosshair BNE.pud
│   ├── Dark Paths BNE.pud
│   ├── Dark Peninsula BNE.pud
│   ├── Forsaken Isles BNE.pud
│   ├── Frosty Fjords BNE.pud
│   ├── Gold Rush BNE.pud
│   ├── Great White North BNE.pud
│   ├── Isolation BNE.pud
│   ├── Kaboom BNE.pud
│   ├── More Precious than Gold BNE.pud
│   ├── Mud in Your Eye BNE.pud
│   ├── Murky River BNE.pud
│   ├── Rose Petal BNE.pud
│   ├── Schwartzwald BNE.pud
│   ├── Skirmish BNE.pud
│   ├── Stir Crazy BNE.pud
│   ├── Taiga BNE.pud
│   ├── The River Kwai BNE.pud
│   ├── Training Ground BNE.pud
│   ├── Widow's End BNE.pud
│   ├── Winding ways BNE.pud
│   └── World Domination BNE.pud
├── battle.snp
├── BNUpdate.exe
├── License.txt
├── Smackw32.dll
├── storm.dll
├── W2Local.dll
├── W2SOUNDS.EXE
├── War2BNEInst.log
├── War2Dat.mpq
├── Warcraft II BNE.exe
├── Warcraft II Map Editor.cnt
├── Warcraft II Map Editor.exe
└── Warcraft II Map Editor.hlp

Hi @timfel thanks for your considerations, I am not a legal expert. Unfortunately using a different version of Warcraft doesn't fix the issue with this one.

SimoneStarace commented 3 years ago

Unfortunately using a different version of Warcraft doesn't fix the issue with this one.

Not even the DOS edition? If you have the GOG edition I can assure you 100% that it works but the only problem is the GOG edition comes only with 3 different languages, unfortunately it doesn't include the Italian language.

timfel commented 3 years ago

At first glance, your directory tree is missing the tomes. In a BNE install, there should be a folder support/tomes/

fvasco commented 3 years ago

Thank you for replies. I found a DOS version here https://giochiabandonware.com/warcraft-2/ and it has been unpacked.

I confirm you that the non working version is labelled: Warcraft II BNE (Battle.net edition) - Blizzard Entertainment 1999 - ITALIANO, Tides of Darkness + Beyond the Dark Portal. However this version can be installed on Windows and works as expected.

SimoneStarace commented 3 years ago

I found a DOS version here https://giochiabandonware.com/warcraft-2/ and it has been unpacked. However this version can be installed on Windows and works as expected.

The only problem with this version is you can't play the Beyond the Dark Portal maps and, I think, you don't have the extra custom maps that comes with the expansion.

timfel commented 3 years ago

The data in the tomes is basically the same as in the DOS version, and that's what our extractor understands. Yes, all the same data is also in the mpq archive, but the extractor would have to be extended for this. It's possible, but I'm chalking this down as "nice to have", since I haven't seen a real CD without the tomes. I have seen some shady sites have zip files without the tomes, I guess because they wanted to save 50MB...

johny-mnemonic commented 3 years ago

I have the same issue with BNE CD (US version). There is no install.mpq file on it. It looks like everything is packed into install.exe file which has 467.8MB.

Also there was a misunderstanding above. The directory structure @fvasco posted is from the already installed game on the disk, while folder support/tomes/ is located on the CD. Files on the CD are from then september of 1999 and install.exe properties shows it is the final 2.0.0 version of BNE. So maybe some late edition, which changed the way how the game was packed on the CD?

timfel commented 3 years ago

Even in the latest version from GOG the support files still exist. The install.exe in the bne edition is just an mpq file, and we can extract all the data from it. But the extraction tool checks for the support folder. One reason is that all legal versions I have seen include that folder and those files, even if they are not needed.

johny-mnemonic commented 3 years ago

@timfel Sure, the support folder (support/tomes/) is there on the CD. I was just saying, that the folder structure @fvasco posted here, was not the folder structure of the CD, but of the installed game (i.e. on C:\ drive). At least when I install the game from my CD, the game on disk looks exactly the same as his folder structure. But as I said, when directing wartool to that big install.exe file it fails to extract anything from it (complaining about no Warcraft 2 data), even though the support folder with tomes exist on the CD. I am executing this:

c:\Program Files (x86)\Wargus>wartool.exe -v -r E:\install.exe c:\Users\johny\Documents\Stratagus\data.Wargus
timfel commented 3 years ago

yeah, wartool expects a folder, not a file 😉 direct to E:\ and it will work

timfel commented 3 years ago

Also, may I ask why you're using wartool directly instead of wargus? The launcher has a bit of logic to sanitize such wrong paths

johny-mnemonic commented 3 years ago

Oh 🤦‍♂️, your right. It works using wargus and also using just the CD path without specifying the install.exe file. Previously I tried really old Warcraft 2 image (1.0 I guess) and it failed from UI and recommended to use command line to see what the exact error was, so I executed it again the same way... So, it now extracted fine from BNE CD for me, thanks!

Maybe @fvasco did the same mistake of pointing wartool to the exe instead of the root of the CD.