Importing the French GOG version result in no French strings imported

[psa-jforestier]

Describe the bug The Warcraft II BNE exists in GOG for French language (also in German), in a separate CD installer (setup_warcraft_ii_2.02_v4_(french)_(28734).exe). The game is all in french : video, voices, campaign scenario and objectives, unit names, UI.

But when I import it with Wargus, only the video are in French.

Looking at the CD content, all the voices are in a GameSFX folder. The Support\TOMES\TOME.4 file contains text, but all in english. I did not find the file where the French labels are stored. They are several .mpq files but none seems to contains French words (I searched for "Chevalier" in all of them and found no occurrence).

I also did some test, by modifying the .po files in scripts\translate\ but the accentuated chars do not working (even if they are in the PNG fonts size). The éàô chars stop the string to be displayed (they are cutted). Even the Spanish version do not display any strings with ó (you should have one at the 1st screen for "Load modificación").

To Reproduce Steps to reproduce the behavior:

1. Import
2. Click on '....'
3. See error

Desktop (please complete the following information):

• OS: Windows 7 32b
• Version 3.1.0 and 3.1.1

[timfel]

Yes, I noticed this about the GoG version for German, too. The game doesn't support accented characters very well, I don't know if/when anyone will have time to fix this.

[timfel]

Also, for Wargus we need separate translations for the unit names etc as po files. Those labels are all not extracted from the CD. Sorry, I was confused about what you were saying. The only thing that should be extracted in French is: videos, voices, and the briefing reading for the missions. All the buttons and unit names etc must be manually translated by us. If you want to contribute a French translation, we'd be happy to include it :)

[psa-jforestier]

Ok, got it for the translated resources. I started to work for po files for units etc, but the lack of accented char make it almost useless (the translations may look like there is a lot of grammal mistakes)

[timfel]

the accented chars can be fixed 🙂

[psa-jforestier]

Are you challenging me ;-) ? I close this issue because it seems there is no easy fix, or I did not understand how the import process work.

I will have a look at how to fix the accented chars bug (if you have any idea on how to start with this bug - I presume it is related to stratagus/src/video/font.cpp )

[timfel]

@psa-jforestier yes, font.cpp has code to convert things to UTF-8 - I'm not sure why that exists, I think it doesn't make sense, since the Warcraft font files look like they are basically ISO 8859-15, so the translation files should simply not be written in UTF-8, but instead in that encoding, and then the game shouldn't do anything to convert from UTF-8, just take the bytes directly and draw them directly using the fonts.

[psa-jforestier]

I found different problem when digging into the code :

• the PO files are in UTF8 which is normal nowadays, so I think we could keep them like that
• the font files (large.png...) do not contains exact ISO8859-15, it more look like an old ASCII extended table (http://www.table-ascii.com/ascii_1.png) the ÿ char is mapped to char number 152 (0x98) in ASCII but is suposed to map to 0xFF in ISO.
• some accented glyphes on the fonts on the glyph grid. They slightly begin before the correct alignment, resulting in bad width computation (the glyph on the left is wider than it must be). Si ï or î on the png file.
• I did a quick and dirty POC, with a UTF-to-ascii look-up-table in font.cpp, and now I'm able to display french, spanish, and german char. I will prepare a PR for that.

[timfel]

Awesome!