Battle.net edition extraction improvements

Wargus / wargus

Importer and scripts for Warcraft II: Tides of Darkness, the expansion Beyond the Dark Portal, and Aleonas Tales

GNU General Public License v2.0

355 stars 55 forks source link

Battle.net edition extraction improvements #380

Closed timfel closed 2 years ago

timfel commented 3 years ago

At least the german gog version of warcraft 2 has the german audio briefings only in the mpq file, the tome file has the english briefings. This PR changes it so the BNet edition gets some more data from the mpq and not the tome files

timfel commented 3 years ago

I found some missing translations in scripts/translate/de_DE.po (and in the other languages), comming from the Option menu :

There's a few more even, also for stratagus-de.po (I used POEdit and clicked the "update from source code" button). For the editor, we have all the extra categories ("Human Shore Buildings", "Orc Land Units" and so on). For network, we have things like "Go Online"... I guess I'll do an update for all of them.

psa-jforestier commented 2 years ago

Hello. I just wan to know the status of this branch. When I tried it like that, I faced two main problems (data source : WC2 GoG in french) :

Extra char at the end of TXT file (mission, credits) => fixed with the "\0" trick (or cleaner refactoring)
Accented char not working on briefing screen : the line is truncated at the 1st accentued char (which is not displayed). => this is because the UTF8 conversion operated by ConvertString() and the CP1252_TABLE is not compatible with the way the Stratagus engine handle UTF8. I had to rewrite some lines of the CP1252_TABLE to make the accented char working, but I can't test it with other languages (german for example).

timfel commented 2 years ago

The status is unfortunately that I don't have time in the near future to finish it. I would like to :( If you or someone else has time to take it over, I am happy to send my German data file over to test with that

psa-jforestier commented 2 years ago

I noticed I have access to the German version with GOG (a single purchase give you all the languages). I m going to give it a try.