search

Wargus / wargus

Importer and scripts for Warcraft II: Tides of Darkness, the expansion Beyond the Dark Portal, and Aleonas Tales
GNU General Public License v2.0
355 stars 55 forks source link

Incompatible lua files error on second multiplayer game #389

Closed Bomfunk closed 2 years ago

Bomfunk commented 2 years ago

Describe the bug After one multiplayer game is successfully played and another one is created, the client no longer can connect, getting the "Incompatible lua files" error, even though both games are the same version, and the data files were copied from one PC to another.

To Reproduce Steps to reproduce the behavior:

  1. Create a game and join it with a client.
  2. Quit to menu on both Wargus instances.
  3. Again create a game and try joining it with a client.
  4. Observe the "Incompatible lua files" on the client.

Expected behavior Successful connection.

Screenshots and Logs Gathered logs: https://drive.google.com/file/d/1mc6GWZmkBgbsX9h3Crgd0XrG3ROnIxIZ/view?usp=sharing

Desktop (please complete the following information):

ipochto commented 2 years ago

Confirm that. The problem is in the continuous lua-files checksum calculation. Every time when any lua-file is loaded checksum is updated. And you will be able to join only if both of client and host checksums are equal. But if order of loading lua-files inconsistent on both machines - they are can't be the same.

timfel commented 2 years ago

This is fixed on master, we do less agressive checksumming now