search

Wargus / wargus

Importer and scripts for Warcraft II: Tides of Darkness, the expansion Beyond the Dark Portal, and Aleonas Tales
GNU General Public License v2.0
355 stars 55 forks source link

Fixes #415 #416

Open SenhorFlibble opened 2 years ago

SenhorFlibble commented 2 years ago

Restore scripts in cannoo directory with extra units, spells, upgrades and buttons for the For the Motherland game mode, and their loading on startup.

For the Motherland mode does not work without these scripts.

SimoneStarace commented 2 years ago

Have you tested if it works with all the available maps?

SenhorFlibble commented 2 years ago

Thanks!

Have you tested if it works with all the available maps?

As I mentioned in the issue description, some maps (e.g. (2)forgotten-forest) crash Wargus, and this was the case in 2.4.3 too. My current level of understanding of the scripts does not allow me to identify the cause of the problems. It appears that some of tem might come from an earlier stage of development and were not fully updated to work with the AI scripts.

Kintobor commented 2 years ago

For the Motherland has two different versions. Two maps use version 2012 and the rest use 2014.

The fork includes a bunch of changes which were never added to the main branch when Wargus was moved from Launchpad to GitHub.

The key difference are the changes to the Frontier Force missions. They have a bunch of beta things. Worth checking out if you are interested in AT.

Get Outlook for Androidhttps://aka.ms/ghei36

From: SenhorFlibble @.> Sent: Thursday, January 13, 2022 1:09:26 AM To: Wargus/wargus @.> Cc: Subscribed @.***> Subject: Re: [Wargus/wargus] Fixes #415 (PR #416)

Thanks!

Have you tested if it works with all the available maps?

As I mentioned in the issue description, some maps (e.g. (2)forgotten-forest) crash Wargus, and this was the case in 2.4.3 too. My current level of understanding of the scripts does not allow me to identify the cause of the problems. It appears that some of tem might come from an earlier stage of development and were not fully updated to work with the AI scripts.

— Reply to this email directly, view it on GitHubhttps://github.com/Wargus/wargus/pull/416#issuecomment-1011082675, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACJENHZJSQLTQMZZKUEOSB3UVWDRNANCNFSM5LWXHTZA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you are subscribed to this thread.Message ID: @.***>

timfel commented 2 years ago

I think I do prefer @SimoneStarace's approach to this, since it separates the scripts a bit more cleanly. I know, the entire lua codebase is a big mess, but we should try to move (slowly) towards having things more clearly separated, having things un- and re-loadable separately etc.

Overall, I'm happy to include these scripts, I just need some time to think about how I can help structure it better.

SimoneStarace commented 2 years ago

I think I do prefer @SimoneStarace's approach to this, since it separates the scripts a bit more cleanly. I know, the entire lua codebase is a big mess, but we should try to move (slowly) towards having things more clearly separated, having things un- and re-loadable separately etc.

Overall, I'm happy to include these scripts, I just need some time to think about how I can help structure it better.

I can make a pull request with only the For the Motherland file being changed if you want.