Human mission 10 instantly fails

[zzam]

Describe the bug DileriumL reported in Discord: When starting the human mission 10 in wargus then the mission is immediately lost.

To Reproduce Steps to reproduce the behavior:

1. Go to 'Single Player Game'
2. Go to 'Campaign Game'
3. Go to 'Tides of Darkness / Alliance'
4. Select mission 10 (X. Die Gefangenen in German)
5. Click 'Start mission'
6. Close the Briefing
7. Immediately the dialog 'You failed to achieve victory' appears.

Expected behavior The game starts and can be played

Screenshots and Logs

Desktop (please complete the following information):

• OS: Gentoo Linux
• Stratagus Version master 2024/04/07, revision 1896f595e21958f4a307531aca77d694d70c9157
• Wargus Version master 2024/04/07, revision 970f948b0696da379bb39f4df8647a5482e8acfc

[zzam]

I verified that stratagus PR 626 (Check each trigger-condition in each cycle) causes the failure.

[zzam]

More details: campaigns/human/level10h_c.sms:

for i,unit in ipairs(GetUnits(4)) do
   if GetUnitVariable(unit, "Ident") == "unit-peasant" then
       TransformUnit(unit, "unit-attack-peasant")
   end
end

In GameCycle=1 the units are still of type unit-peasant. In GameCycle=2 the units are of type unit-attack-peasant.

Before PR 626, in GameCycle=1 the first trigger was checked (IfRescuedNearUnit). In GameCycle=2 the second trigger (the problematic one, GetPlayerData ....) was executed. Switching the order of triggers would also have broken it.

Now all triggers are executed in each cycle and it fails now in GameCycle=1 running the second trigger.

Options to fix it:

1. wargus: Adjust trigger code of mission to only run when GameCycle>=2:

   AddTrigger(
   function() 
   return GameCycle > 1 and (GetPlayerData(4, "UnitTypesCount", "unit-attack-peasant") + 
   GetPlayerData(GetThisPlayer(), "UnitTypesCount", "unit-attack-peasant")) <= 3 end,
   function() return ActionDefeat() end)

2. wargus: Adjust trigger to also count unit-peasant
3. wargus: Adjust mission to use a replaced CreateUnit function that directly replaces the unit-type for player 4.
4. Stratagus: run triggers only at GameCycle>=2 (or maybe even later).
5. Stratagus: Change TransformUnit to have immediate effect.